-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Containerized mounts #278
Comments
@jsafrane please, don't forget about the design proposal link. |
The design proposal - kubernetes/community#589 |
slipped from 1.7 |
There are two design proposals:
|
Automatic merge from submit-queue (batch tested with PRs 46458, 50934, 50766, 50970, 47698) Prepare VolumeHost for running mount tools in containers This is the first part of implementation of kubernetes/enhancements#278 - running mount utilities in containers. It updates `VolumeHost` interface: * `GetMounter()` now requires volume plugin name, as it is going to return different mounter to different volume plugings, because mount utilities for these plugins can be on different places. * New `GetExec()` method that should volume plugins use to execute any utilities. This new `Exec` interface will execute them on proper place. * `SafeFormatAndMount` is updated to the new `Exec` interface. This is just a preparation, `GetExec` right now leads to simple `os.Exec` and mount utilities are executed on the same place as before. Also, the volume plugins will be updated in subsequent PRs (split into separate PRs, some plugins required lot of changes). ```release-note NONE ``` @kubernetes/sig-storage-pr-reviews @rootfs @gnufied
this has been discussed and the feature approved during sig-storage calls and 1-off designs. |
sig-storage strongly supports this feature. We really need this to get in for 1.8. |
Automatic merge from submit-queue (batch tested with PRs 46458, 50934, 50766, 50970, 47698) Prepare VolumeHost for running mount tools in containers This is the first part of implementation of kubernetes/enhancements#278 - running mount utilities in containers. It updates `VolumeHost` interface: * `GetMounter()` now requires volume plugin name, as it is going to return different mounter to different volume plugings, because mount utilities for these plugins can be on different places. * New `GetExec()` method that should volume plugins use to execute any utilities. This new `Exec` interface will execute them on proper place. * `SafeFormatAndMount` is updated to the new `Exec` interface. This is just a preparation, `GetExec` right now leads to simple `os.Exec` and mount utilities are executed on the same place as before. Also, the volume plugins will be updated in subsequent PRs (split into separate PRs, some plugins required lot of changes). ```release-note NONE ``` @kubernetes/sig-storage-pr-reviews @rootfs @gnufied
Slipped from 1.8 |
@jsafrane 👋 Please indicate in the 1.9 feature tracking board UPDATE: Thanks for the update: no docs required. 👍 |
Relevant PR that went into 1.9 is: kubernetes/kubernetes#53440 Also this feature is alpha in 1.9 NOT beta. Relabeling. |
Automatic merge from submit-queue (batch tested with PRs 46458, 50934, 50766, 50970, 47698) Prepare VolumeHost for running mount tools in containers This is the first part of implementation of kubernetes/enhancements#278 - running mount utilities in containers. It updates `VolumeHost` interface: * `GetMounter()` now requires volume plugin name, as it is going to return different mounter to different volume plugings, because mount utilities for these plugins can be on different places. * New `GetExec()` method that should volume plugins use to execute any utilities. This new `Exec` interface will execute them on proper place. * `SafeFormatAndMount` is updated to the new `Exec` interface. This is just a preparation, `GetExec` right now leads to simple `os.Exec` and mount utilities are executed on the same place as before. Also, the volume plugins will be updated in subsequent PRs (split into separate PRs, some plugins required lot of changes). ```release-note NONE ``` @kubernetes/sig-storage-pr-reviews @rootfs @gnufied
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
@jsafrane @saad-ali If so, can you please ensure the feature is up-to-date with the appropriate:
cc @idvoretskyi |
@justaugustus @idvoretskyi, I updated the feature description. This feature will never reach beta or stable, we plan to use it only in e2e tests. Perhaps we can close this issue as all the work for the feature has been done. [Now we need to actually use the feature in e2e tests, but that's another story] |
That's interesting - What's the reason for not targeting it for beta/GA? |
@jsafrane Okay, I'm going to close this out, but if you need to reopen for any reason, feel free! |
It's dangerous. We want to reduce the options how volume plugins are working. We already have enough problems with containerized kubelet. Note that a Flex driver can be deployed in containers already, it's orthogonal to this feature. And CSI basically requires to deploy mount utilities in containers. |
Might just want to clarify. Containerizing just the mount tools (so that stuff like the native ceph driver can work) is the thing not going forward. The ability to share mounts outside of a container, or have whole drivers (csi) is staying. So the end goal of having all the things in containers is still moving forward, just without this particular implementation? |
Yes. The end goal is CSI - CSI drivers may (and often must) containerize their tools and Kubernetes does not need to be changed in any way. |
Automatic merge from submit-queue (batch tested with PRs 46458, 50934, 50766, 50970, 47698) Prepare VolumeHost for running mount tools in containers This is the first part of implementation of kubernetes/enhancements#278 - running mount utilities in containers. It updates `VolumeHost` interface: * `GetMounter()` now requires volume plugin name, as it is going to return different mounter to different volume plugings, because mount utilities for these plugins can be on different places. * New `GetExec()` method that should volume plugins use to execute any utilities. This new `Exec` interface will execute them on proper place. * `SafeFormatAndMount` is updated to the new `Exec` interface. This is just a preparation, `GetExec` right now leads to simple `os.Exec` and mount utilities are executed on the same place as before. Also, the volume plugins will be updated in subsequent PRs (split into separate PRs, some plugins required lot of changes). ```release-note NONE ``` @kubernetes/sig-storage-pr-reviews @rootfs @gnufied
Proposal: Add Tag Indicating To Replace Union Fields in Patch
Feature Description
One-line feature description (can be used as a release note):
Kubernetes can run mount utilities in pods instead on the host.
Primary contact (assignee): @jsafrane
Responsible SIGs: sig-storage, sig-node
Design proposal link (community repo): Proposal: containerized mount utilities in pods community#589
Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
Approver (likely from SIG/area to which feature belongs): @saad-ali
Initial target stage (alpha/beta/stable) and release (x.y):
1.71.81.9The text was updated successfully, but these errors were encountered: