-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change ingress_upstream_latency_seconds metrics type to Histogram #8397
Conversation
@Lyt99: This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @Lyt99. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
452eaf1
to
1935251
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Lyt99 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks, it's on my list, I will review it asap /assign |
Hi @tao12345666333, any progress here? |
1935251
to
d432a57
Compare
d432a57
to
8d1609b
Compare
/ok-to-test |
BTW, #8726 added a new Summary type metric, I'm afraid that this feature will also trigger the problem. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
@Lyt99: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
Close, please checkout #8285 for the reason. |
Change metrics
ingress_upstream_latency_seconds
type fromSummary
toHistogram
, and both change the example grafana dashboard to use new metrics type.What this PR does / why we need it:
It fixes #8285, and may fixes #8228.
We have met this problem in benchmark and production environment.
When use
Summary
metric type with a heavy load , theSummary
need to recalculate the quantitate, which is expensive and not lock-free. It will block other metric requests, consume large amount of memory, and get OOM killed.Change
Summary
to lock-freeHistogram
would solve the problem. But introduce breaking change.Types of changes
Which issue/s this PR fixes
fixes #8285 and #8228
How Has This Been Tested?
nginx-ingress-controller
with only 1 replica.wrk
with template below to benchmark it. Replace<Controller Endpoint IP>
to real endpoint IP.Checklist: