Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add staging for git-sync #1216

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Add staging for git-sync #1216

merged 1 commit into from
Sep 8, 2020

Conversation

thockin
Copy link
Member

@thockin thockin commented Sep 4, 2020

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. labels Sep 4, 2020
@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects approved Indicates a PR has been approved by an approver from all required OWNERS files. wg/k8s-infra labels Sep 4, 2020
@stp-ip
Copy link
Member

stp-ip commented Sep 5, 2020

+1 from me, but as I am one of the reviewers listed not doing to lgtm etc.

justaugustus
justaugustus suggested changes Sep 5, 2020
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @thockin -- I think you'll need to actuate the project in

k8s.io/infra/gcp/ensure-staging-storage.sh

Line 43 in af78aa9

STAGING_PROJECTS=(
, right?

@thockin
Copy link
Member Author

thockin commented Sep 6, 2020

fixed!

@justaugustus
Copy link
Member

Thanks Tim!
/lgtm

@dims
Copy link
Member

dims commented Sep 6, 2020

/approve
/lgtm

/hold what's this for again?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stp-ip
Copy link
Member

stp-ip commented Sep 6, 2020

/hold what's this for again?

git-sync is a project done at k/git-sync and is therefore in the vicinity of Kubernetes. It's main use is as a git pulling sidecar.
Container builds and publishing is currently done manually by Tim and with this PR would be moved to be governed by 2 people instead of one and also open to non googlers. Also open to be automated as well later etc. pp.

@dims
Copy link
Member

dims commented Sep 7, 2020

Ack @stp-ip we can remove hold when someone runs the script for creating the staging repo.

@thockin
Copy link
Member Author

thockin commented Sep 8, 2020

Group added.

@dims
Copy link
Member

dims commented Sep 8, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5b724a9 into kubernetes:master Sep 8, 2020
@thockin
Copy link
Member Author

thockin commented Sep 8, 2020

Staging created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus requested changes

@dims dims Awaiting requested review from dims

@mikedanese mikedanese Awaiting requested review from mikedanese

Assignees

@dims dims

@justaugustus justaugustus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thockin @stp-ip @justaugustus @dims @k8s-ci-robot