Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes-public: add bucket k8s-cve-feed #4009

Merged
merged 2 commits into from
Jul 29, 2022
Merged

kubernetes-public: add bucket k8s-cve-feed #4009

merged 2 commits into from
Jul 29, 2022

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Jul 25, 2022

Related to:

Add a world-readable bucket for official k8s CVE list along a service
account.

Signed-off-by: Arnaud Meukam ameukam@gmail.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/infra Infrastructure management, infrastructure design, code in infra/ area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2022
@ameukam
Copy link
Member Author

ameukam commented Jul 25, 2022

/hold
/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. labels Jul 25, 2022
@PushkarJ
Copy link
Member

Thank you so much @ameukam for creating this PR. Let us know if you need any info from me or @nehaLohia27

This was referenced Jul 25, 2022
Open
Merged
@ameukam
Bump terraform required version and GCP provider
8ec80b3 
Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@ameukam
kubernetes-public: add bucket k8s-cve-feed
d9b9952 
Add a world-readable bucket for official k8s CVE list along a service
account.

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@ameukam
Copy link
Member Author

ameukam commented Jul 29, 2022

Thank you so much @ameukam for creating this PR. Let us know if you need any info from me or @nehaLohia27

@PushkarJ a lgtm is more than welcome.

@PushkarJ
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2022
@ameukam
Copy link
Member Author

ameukam commented Jul 29, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2022
@k8s-ci-robot k8s-ci-robot merged commit dae5ae2 into kubernetes:main Jul 29, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jul 29, 2022
@ameukam
Copy link
Member Author

ameukam commented Jul 29, 2022

Buckets and service accounts have been created.

@PushkarJ PushkarJ mentioned this pull request Jul 29, 2022
Closed
@ameukam ameukam mentioned this pull request Aug 8, 2022
Merged
@hakman hakman mentioned this pull request Aug 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato Awaiting requested review from cpanato

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@PushkarJ PushkarJ

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/infra Infrastructure management, infrastructure design, code in infra/ area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
3 participants
@ameukam @k8s-ci-robot @PushkarJ