Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image promotion for cluster-api-azure v1.4.3 #4280

Closed
wants to merge 1 commit into from
Closed

Image promotion for cluster-api-azure v1.4.3 #4280

wants to merge 1 commit into from
+1 −0

Conversation

CecileRobertMichon
Copy link
Member

Image promotion for cluster-api-azure v1.4.3
This is an automated PR generated from kpromo

kpromo pr --fork CecileRobertMichon --project cluster-api-azure --reviewers "@alexeldeib @CecileRobertMichon @devigned @jackfrancis @mboersma" --tag v1.4.3

/hold
cc: @alexeldeib @CecileRobertMichon @devigned @jackfrancis @mboersma

@CecileRobertMichon
Image promotion for cluster-api-azure v1.4.3
f853d6c 
Signed-off-by: Cecile Robert-Michon <cecilerobertm@gmail.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 28, 2022
@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/k8s.gcr.io Code in k8s.gcr.io/ area/provider/azure Issues or PRs related to azure provider labels Sep 28, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 28, 2022
@CecileRobertMichon
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 28, 2022
@CecileRobertMichon
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 28, 2022
mboersma
mboersma reviewed Sep 28, 2022
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 28, 2022
@CecileRobertMichon
Copy link
Member Author

Holding for now because we're verifying if we need to backport a missing cherry-pick

@CecileRobertMichon CecileRobertMichon deleted the cluster-api-azure-v1.4.3-image-promotion branch September 28, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboersma mboersma mboersma left review comments

@Jont828 Jont828 Awaiting requested review from Jont828

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

Assignees

@mboersma mboersma

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/k8s.gcr.io Code in k8s.gcr.io/ area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CecileRobertMichon @k8s-ci-robot @mboersma