Add zone configurations for k8s-e2e.com and x-k8s.io #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/approve |
k8s-ci-robot
added
area/dns
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
thockin
reviewed
Jan 8, 2020
| @@ -22,6 +22,16 @@ zones: | |||
| - config | |||
| targets: | |||
| - gcp | |||
| canary.k8s-e2e.com.: | |||
There was a problem hiding this comment.
What is this? Did we buy it? Does CNCF own it? What is it for and why is it a new domain rather than a subdomain of k8s.io ?
There was a problem hiding this comment.
It's a zone specific for some e2e tests we have. Yes, CNCF owns it and delegated it to us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been tested and pushed. Zones were manually created in kubernetes-public.
/assign @thockin