Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zone configurations for k8s-e2e.com and x-k8s.io #526

Merged
merged 1 commit into from Jan 6, 2020

Conversation

@cblecker
Copy link
Member

cblecker commented Dec 30, 2019

This has been tested and pushed. Zones were manually created in kubernetes-public.

/assign @thockin

@cblecker

This comment has been minimized.

Copy link
Member Author

cblecker commented Dec 30, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims

This comment has been minimized.

Copy link
Member

dims commented Jan 6, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit 57e28eb into kubernetes:master Jan 6, 2020
1 of 2 checks passed
1 of 2 checks passed
tide Not mergeable. Needs lgtm label.
Details
cla/linuxfoundation cblecker authorized
Details
@cblecker cblecker deleted the cblecker:new-zones branch Jan 6, 2020
Copy link
Member

thockin left a comment

Forgot to update README.md

Forgot to update infra/gcp/ensure-main-project.sh

@@ -22,6 +22,16 @@ zones:
- config
targets:
- gcp
canary.k8s-e2e.com.:

This comment has been minimized.

Copy link
@thockin

thockin Jan 8, 2020

Member

What is this? Did we buy it? Does CNCF own it? What is it for and why is it a new domain rather than a subdomain of k8s.io ?

This comment has been minimized.

Copy link
@cblecker

cblecker Jan 8, 2020

Author Member

It's a zone specific for some e2e tests we have. Yes, CNCF owns it and delegated it to us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.