Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure IRSA for node e2e tests in dev account #5409

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

upodroid
Copy link
Member

/cc @dims

I'm using the playground account created in #4884 to run the e2e tests for now. These jobs will need to run in their own dedicated accounts later.

I manually created the role on the 855606814420 account with reasonable permisisons.

[cloudshell-user@ip-10-6-84-235 ~]$ aws iam get-role --role-name node-e2e-tests 
{
    "Role": {
        "Path": "/",
        "RoleName": "node-e2e-tests",
        "RoleId": "AROA4ONRD43KG4Y7CFLIJ",
        "Arn": "arn:aws:iam::855606814420:role/node-e2e-tests",
        "CreateDate": "2023-06-13T17:22:21+00:00",
        "AssumeRolePolicyDocument": {
            "Version": "2012-10-17",
            "Statement": [
                {
                    "Effect": "Allow",
                    "Principal": {
                        "Federated": "arn:aws:iam::855606814420:oidc-provider/oidc.eks.us-east-2.amazonaws.com/id/F8B73554FE6FBAF9B19569183FB39762"
                    },
                    "Action": "sts:AssumeRoleWithWebIdentity",
                    "Condition": {
                        "StringEquals": {
                            "oidc.eks.us-east-2.amazonaws.com/id/F8B73554FE6FBAF9B19569183FB39762:aud": "sts.amazonaws.com"
                        }
                    }
                }
            ]
        },
        "Description": "",
        "MaxSessionDuration": 3600,
        "RoleLastUsed": {}
    }
}
[cloudshell-user@ip-10-6-84-235 ~]$ aws iam list-attached-role-policies --role-name node-e2e-tests 
{
    "AttachedPolicies": [
        {
            "PolicyName": "AmazonEC2FullAccess",
            "PolicyArn": "arn:aws:iam::aws:policy/AmazonEC2FullAccess"
        },
        {
            "PolicyName": "EC2InstanceConnect",
            "PolicyArn": "arn:aws:iam::aws:policy/EC2InstanceConnect"
        }
    ]
}

@k8s-ci-robot k8s-ci-robot requested a review from dims June 13, 2023 17:32
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/infra Infrastructure management, infrastructure design, code in infra/ area/infra/aws Issues or PRs related to Kubernetes AWS infrastructure sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 13, 2023
@dims
Copy link
Member

dims commented Jun 13, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9804854 into kubernetes:main Jun 13, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/infra/aws Issues or PRs related to Kubernetes AWS infrastructure area/infra Infrastructure management, infrastructure design, code in infra/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants