Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OWNERS_ALIASES from community repo #6115

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Update OWNERS_ALIASES from community repo #6115

merged 2 commits into from
Nov 24, 2023

Conversation

cblecker
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 22, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 22, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 22, 2023
@cblecker cblecker mentioned this pull request Nov 22, 2023
Closed
15 tasks
@upodroid
Copy link
Member

Hey, do you want the update the root OWNERS file with 2 other sig-contribex TLs and remove @cblecker and @nikhita?

@cblecker
Copy link
Member Author

Oh, good call @upodroid.. taking a look.

@ameukam ameukam mentioned this pull request Nov 24, 2023
Merged
@mrbobbytables
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit 648468d into kubernetes:main Nov 24, 2023
3 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Nov 24, 2023
@cblecker cblecker deleted the update-aliases branch November 24, 2023 13:57
dulek added a commit to dulek/k8s.io that referenced this pull request Jan 18, 2024
@dulek
Fix cloud-provider-openstack approvers
53c92d8 
PR kubernetes#6115 broke this list of approvers by updating its name in
OWNERS_ALIASES but never in OWNERS file using that alias. This commit
solves that.
@dulek dulek mentioned this pull request Jan 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin Awaiting requested review from thockin

@upodroid upodroid Awaiting requested review from upodroid

Assignees

@mrbobbytables mrbobbytables

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cblecker @k8s-ci-robot @upodroid @mrbobbytables