forked from golang/glog
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cases where KMetadata interface has nil object #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
labels
Mar 12, 2021
k8s-ci-robot
added
the
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
Mar 12, 2021
serathius
force-pushed
the
fix-nil
branch
3 times, most recently
from
March 12, 2021 14:26
3d6518b
to
045efe9
Compare
Removing WIP as benchmark results look reasonable |
serathius
changed the title
[WIP] Fix cases where KMetadata interface has nil object
Fix cases where KMetadata interface has nil object
Mar 12, 2021
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Mar 12, 2021
serathius
force-pushed
the
fix-nil
branch
2 times, most recently
from
March 12, 2021 14:46
35c387b
to
b887978
Compare
k8s-ci-robot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Mar 12, 2021
Fixed how benchmark is implemented |
serathius
force-pushed
the
fix-nil
branch
2 times, most recently
from
March 12, 2021 15:04
648ad63
to
61753a1
Compare
LGTM, i'd like a second opinion/review from @liggitt or @DirectXMan12 |
liggitt
reviewed
Mar 12, 2021
liggitt
reviewed
Mar 12, 2021
serathius
force-pushed
the
fix-nil
branch
2 times, most recently
from
March 12, 2021 16:43
4d032b0
to
7d066fe
Compare
Updated benchmark results, looks better around 7% difference. |
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Mar 12, 2021
done, PTAL @liggitt |
This was referenced Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE, this is one of the alternatives considered to fix kubernetes/kubernetes#100155
What this PR does / why we need it:
Fixes passing
nil
object toklog.KObj
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes kubernetes/kubernetes#100155
Special notes for your reviewer:
Added benchmark run them with
go test -bench=BenchmarkKObj -count=100 -benchmem -run=^$
and got results analysed by benchstat:We see around 19% worse performance by introducing reflections, still looks acceptable.
Release note: