Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes redundant services are printed/converted in kompose convert #20

Closed
janetkuo opened this issue Jul 6, 2016 · 2 comments
Closed
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@janetkuo
Copy link
Member

janetkuo commented Jul 6, 2016

Note that there's a redundant file "web-svc.json" created message.

examples(master)$ ../kompose convert 
file "web-rc.json" created
file "web-svc.json" created
file "redis-rc.json" created
file "web-svc.json" created
file "redis-svc.json" createdexamples(master)$ ../kompose convert 
file "redis-rc.json" created
file "web-rc.json" created
file "redis-svc.json" created
file "web-svc.json" created
@ngtuna
Copy link
Contributor

ngtuna commented Jul 7, 2016

Yup. Also I have to re-structure convert function. It's too long and difficult to follow somehow.

@ngtuna ngtuna added kind/bug Categorizes issue or PR as related to a bug. v0.0.1 labels Jul 7, 2016
@ngtuna
Copy link
Contributor

ngtuna commented Jul 7, 2016

Done. Convert function is now more easier to keep track. Issue is also fixed by 2e986b6

@ngtuna ngtuna closed this as completed Jul 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants