Do not start dns-controller with '- --watch-ingress=false'

[kenden]

I am trying to create a route53 entry matching an nginx ingress-controller from an ingress.
After failing, I found the root cause: this is disabled:

kubectl get pod dns-controller-3905064033-hltml -n kube-system -o yaml
...
spec:
  containers:
  - command:
    - /usr/bin/dns-controller
    - --watch-ingress=false
    - --dns=aws-route53
    - --zone=stylight.net
    - --zone=*/*
    - -v=2
    image: kope/dns-controller:1.5.2
...

--watch-ingress=false

I saw in a few places:
#551 (comment)
#1413 (comment)
that this is expected.

Could this be enabled by default?

I could change this from:
<kops_s3_bucket>/addons/dns-controller.addons.k8s.io/v1.5.2.yaml
but that's one more piece of default config I would need to change and I'd like to stick to defaults as much as possible.

[geojaz]

This is a really good point. I think it slipped through the cracks since we were waiting for a new version back in winter.

@justinsb Has this been fixed upstream? I looked, but I'm not sure.

[chrislovecnm]

@geojaz is this upstream? This is our addon I think

[geojaz]

@chrislovecnm I believe the original problem was with ingress-controller, but it was back in like Jan. Apparently they've done their side: #1413 (comment)
I think we can re-enable the flags now, unless @justinsb sees a problem with it.

[chrislovecnm]

closing

[kenden]

"Fix" reverted by #2560
Proper fix would be with #2504