Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Would be safest to delete the /etc/kubernetes/manifests before mounting disk #81

Closed
justinsb opened this issue Jul 7, 2016 · 2 comments
Closed

Would be safest to delete the /etc/kubernetes/manifests before mounting disk #81

justinsb opened this issue Jul 7, 2016 · 2 comments
Labels
P2
Milestone
1.5.2

Comments

@justinsb
Copy link
Member

justinsb commented Jul 7, 2016

We have a symlink from /etc/kubernetes/manifests to a manifest on the volume, to avoid the race in #73.

But once the mount the volume, it is possible that a different manifest exists, and the symlink then resolves.

It would be safer to delete the symlink before mounting the volume. Another option would be to use a UUID in the mount path.

I'm not sure this actually matters much, because the manifest shouldn't be changing anyway. But we should probably fix to prevent future issues.
@justinsb justinsb added the P2 label Jul 8, 2016
@justinsb justinsb added this to the 1.3.2 milestone Aug 15, 2016
@justinsb justinsb modified the milestones: 1.4.5, 1.5.0, 1.5.1 Dec 28, 2016
@blakebarnett
Copy link

Should we bump this again or just close it? Seems to not be causing issues.

@chrislovecnm
Copy link
Contributor

Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2
Projects
None yet
Milestone
1.5.2
Development

No branches or pull requests
3 participants
@justinsb @chrislovecnm @blakebarnett