-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Flatcar containerd exec command #12900
Simplify Flatcar containerd exec command #12900
Conversation
Welcome @pothos! |
Hi @pothos. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks @pothos. :) |
The containerd command used in #12177 is a modification from the torcx containerd unit. However, how torcx starts containerd is a implementation detail and it's better to not hardcode torcx in case it isn't used anymore. Change the ExecStard command to use /usr/bin/containerd directly, making it simpler and more future-proof.
Now with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pothos. Looking forward to see the periodic tests go green once the IMDSv2 issue is also addressed. Will take care of the cherry-picks soon.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…-upstream-release-1.21 Automated cherry pick of #12900: Simplify Flatcar containerd exec command
…-upstream-release-1.22 Automated cherry pick of #12900: Simplify Flatcar containerd exec command
The containerd command used in
#12177 is a modification from
the torcx containerd unit. However, how torcx starts containerd is a
implementation detail and it's better to not hardcode torcx in case it
isn't used anymore.
Change the ExecStard command to use /usr/bin/containerd directly,
making it simpler and more future-proof.