Automated cherry pick of #12900: Simplify Flatcar containerd exec command #13258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The containerd command used in kubernetes#12177 is a modification from the torcx containerd unit. However, how torcx starts containerd is a implementation detail and it's better to not hardcode torcx in case it isn't used anymore. Change the ExecStard command to use /usr/bin/containerd directly, making it simpler and more future-proof.
k8s-ci-robot
added
cncf-cla: yes
|
/retest |
olemarkus
approved these changes
Feb 17, 2022
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
hakman
deleted the
automated-cherry-pick-of-#12900-upstream-release-1.21
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #12900 on release-1.21.
#12900: Simplify Flatcar containerd exec command
For details on the cherry pick process, see the cherry pick requests page.