-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly detect GovCloud regions #13410
Conversation
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
|
/check-cla |
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mixja. 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…-upstream-release-1.22 Automated cherry pick of #13410: Correctly detect GovCloud regions
…-upstream-release-1.23 Automated cherry pick of #13410: Correctly detect GovCloud regions
This PR correctly detects S3 HTTP URLs in GovCloud regions for
spec.assets.fileRepository
.e.g. this is the S3 object URL format for GovCloud
Prior to this PR, the bucket name is captured incorrectly in the example above as
s3-us-gov-west-1
.