Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #13410: Correctly detect GovCloud regions #13416

Conversation

hakman
Copy link
Member

@hakman hakman commented Mar 26, 2022

Cherry pick of #13410 on release-1.23.

#13410: Correctly detect GovCloud regions

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Mar 26, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 26, 2022
@hakman
Copy link
Member Author

hakman commented Mar 26, 2022

pull-kops-verify-govet will pass when #13418 is merged.

@hakman
Copy link
Member Author

hakman commented Mar 26, 2022

/cc @olemarkus

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2022
@hakman
Copy link
Member Author

hakman commented Mar 26, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit fd4e9c3 into kubernetes:release-1.23 Mar 26, 2022
@hakman hakman deleted the automated-cherry-pick-of-#13410-upstream-release-1.23 branch March 28, 2022 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants