Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update default runc to 1.1.5, add 1.1.6 and 1.1.7 #15358

Merged
merged 4 commits into from
May 3, 2023
Merged

update default runc to 1.1.5, add 1.1.6 and 1.1.7 #15358

merged 4 commits into from
May 3, 2023

Conversation

heybronson
Copy link
Contributor

@heybronson heybronson commented May 2, 2023 •
edited
Loading

Including runc 1.1.7 to resolve GPU issues described in NVIDIA/nvidia-docker#1671 (comment)

Setting default runc version to 1.1.5.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 2, 2023
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 2, 2023
@heybronson
Copy link
Contributor Author

/test pull-kops-e2e-cni-cilium

@heybronson
Copy link
Contributor Author

/test pull-kops-e2e-cni-cilium-etcd

@heybronson
Copy link
Contributor Author

/test pull-kops-e2e-cni-kuberouter

hakman
hakman reviewed May 3, 2023
View reviewed changes
pkg/model/components/containerd.go Outdated
@@ -49,7 +49,7 @@ func (b *ContainerdOptionsBuilder) BuildOptions(o interface{}) error {
if b.IsKubernetesGTE("1.23") {
containerd.Version = fi.PtrTo("1.6.20")
containerd.Runc = &kops.Runc{
Version: fi.PtrTo("1.1.4"),
Version: fi.PtrTo("1.1.7"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heybronson Could you try setting the default to 1.1.5?
I think there's something broken with the latest releases of runc. We should probably create an issue with https://github.com/opencontainers/runc.

Suggested change
Version: fi.PtrTo("1.1.7"),
Version: fi.PtrTo("1.1.5"),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do, thanks for the response!

Copy link
Member

@hakman hakman May 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait until Friday to discuss the issue during office hours. It is pretty clear that it only affects GCE and I guess it's the CSI related tests.
#15322 (comment)

@hakman
Copy link
Member

hakman commented May 3, 2023

/test pull-kops-aws-distro-ubuntu2204

@heybronson heybronson changed the title update runc to 1.1.7 update default runc to 1.1.5, add 1.1.6 and 1.1.7 May 3, 2023
@heybronson
Copy link
Contributor Author

/retest

@hakman
Copy link
Member

hakman commented May 3, 2023

This looks much better...

@hakman
Copy link
Member

hakman commented May 3, 2023

/test pull-kops-e2e-cni-cilium-etcd

@heybronson
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 3, 2023 •
edited
Loading

@heybronson: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-cni-kuberouter d819068 link false /test pull-kops-e2e-cni-kuberouter

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit c7b5e70 into kubernetes:master May 3, 2023
@heybronson heybronson deleted the runc-1.1.7 branch May 3, 2023 19:34
This was referenced May 3, 2023
Closed
Closed
This was referenced May 3, 2023
Closed
Closed
@hakman hakman mentioned this pull request May 10, 2023
Merged
k8s-ci-robot added a commit that referenced this pull request May 13, 2023
@k8s-ci-robot
Merge pull request #15391 from hakman/automated-cherry-pick-of-#15319-#…
9d54a2d 
…15358-#15378-upstream-release-1.26

Automated cherry pick of #15319: Update containerd to v1.6.20
#15358: update runc to 1.1.7
#15378: Update containerd to v1.6.21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@heybronson @hakman @k8s-ci-robot