Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #8462: Tag EBS volumes when using launch templates with AWS API #8665

Conversation

rifelpet
Copy link
Member

@rifelpet rifelpet commented Mar 3, 2020

Cherry pick of #8462 on release-1.17.

#8462: Tag EBS volumes when using launch templates with AWS API

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Mar 3, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2020
@johngmyers
Copy link
Member

johngmyers commented Mar 3, 2020

If you backport this, you'll want to backport #8660 as well. But #8660 is moderately risky due to adding tags to ASGs, LauchConfigurations, and the instances they launch.

@hakman has found a number of issues with EnableLaunchTemplates. I am not sure we should be backporting them into 1.17 now that it's in beta.

@hakman
Copy link
Member

hakman commented Mar 3, 2020

@rifelpet @johngmyers I think #8660 can be skipped, but #8466 needs to be added.

@hakman
Copy link
Member

hakman commented Mar 27, 2020

@rifelpet I cherrypicked both required fixes in #8805 and #8806. I think this can be closed.

@rifelpet
Copy link
Member Author

/close

@k8s-ci-robot
Copy link
Contributor

@rifelpet: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rifelpet rifelpet deleted the automated-cherry-pick-of-#8462-origin-release-1.17 branch August 6, 2020 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants