Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"kubeadm config upload from-flags" shouldn't upload kubeadm version #470

Closed
medinatiger opened this issue Sep 27, 2017 · 5 comments
Closed
Labels
area/upgrades kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@medinatiger
Copy link

Is this a BUG REPORT or FEATURE REQUEST?

BUG REPORT

Versions

kubeadm version (use kubeadm version):
root@k8s-m:~# kubeadm version
kubeadm version: &version.Info{Major:"1", Minor:"8+", GitVersion:"v1.8.0-rc.1", GitCommit:"c8a2429cb355d357d90174d3744a930dbd0bbff6", GitTreeState:"clean", BuildDate:"2017-09-23T01:24:52Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}

Environment:

  • Kubernetes version (use kubectl version):
    root@k8s-m:~# kubectl version
    Client Version: version.Info{Major:"1", Minor:"7", GitVersion:"v1.7.6", GitCommit:"4bc5e7f9a6c25dc4c03d4d656f2cefd21540e28c", GitTreeState:"clean", BuildDate:"2017-09-14T06:55:55Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}
    Server Version: version.Info{Major:"1", Minor:"7", GitVersion:"v1.7.6", GitCommit:"4bc5e7f9a6c25dc4c03d4d656f2cefd21540e28c", GitTreeState:"clean", BuildDate:"2017-09-14T06:36:08Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}

  • Cloud provider or hardware configuration:

  • OS (e.g. from /etc/os-release):
    root@k8s-m:~# cat /etc/os-release
    NAME="Ubuntu"
    VERSION="17.04 (Zesty Zapus)"
    ID=ubuntu
    ID_LIKE=debian
    PRETTY_NAME="Ubuntu 17.04"
    VERSION_ID="17.04"
    HOME_URL="https://www.ubuntu.com/"
    SUPPORT_URL="https://help.ubuntu.com/"
    BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
    PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
    VERSION_CODENAME=zesty
    UBUNTU_CODENAME=zesty

  • Kernel (e.g. uname -a):
    Linux k8s-m 4.10.0-35-generic CentOS 7 hangs at "created API client, waiting for the control plane to become ready" #39-Ubuntu SMP Wed Sep 13 07:46:59 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

  • Others:

What happened?

"kubeadm config upload from-flags" tries to pull the version for kubeadm instead of the kube cluster. If the kubeadm is a CI version w/o a stable label, things get weird.

root@k8s-m:# kubeadm config upload from-flags
unable to fetch file. URL: "https://dl.k8s.io/release/stable-1.8.txt" Status: 404 Not Found
root@k8s-m:
# kubeadm config upload from-flags

What you expected to happen?

kubeadm shouldn't try to care its own version when upgrading cluster config.

How to reproduce it (as minimally and precisely as possible)?

kubeadm config upload from-flags

On a v1.7.6 cluster, When we use v1.8.0-rc.1 kubeadm

Anything else we need to know?

@pipejakob
Copy link
Contributor

This was also reported in #466.

@medinatiger
Copy link
Author

The following command works.

kubeadm config upload from-flags --kubernetes-version=v1.7.6

Anyway, when kubernetes-version is not specified, kubeadm should try to get cluster version rather than kubeadm version.

@jamiehannaford jamiehannaford added area/upgrades kind/bug Categorizes issue or PR as related to a bug. labels Oct 6, 2017
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 7, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 10, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/upgrades kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants