Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subresource managedfields #100970

Merged
merged 3 commits into from
Apr 17, 2021
Merged

Add subresource managedfields #100970

merged 3 commits into from
Apr 17, 2021

Conversation

apelisse
Copy link
Member

@apelisse apelisse commented Apr 9, 2021

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds a new subresource field in the managedFieldsEntry

Special notes for your reviewer:

This is more or less a replicate of #99210 which was very close to being merged.
It's also the base of #98377 and #100496.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 9, 2021
@apelisse
Copy link
Member Author

apelisse commented Apr 9, 2021

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/apiserver area/code-generation area/test and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 9, 2021
@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 9, 2021
@apelisse apelisse added this to the v1.22 milestone Apr 9, 2021
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@fejta-bot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.
/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 9, 2021
@k8s-ci-robot
Copy link
Contributor

@apelisse: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@apelisse apelisse force-pushed the add-subresource-managedfields branch from 0aefb7a to 9025813 Compare April 15, 2021 22:05
@apelisse
Copy link
Member Author

Simple validation added and rebased on recent master.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 15, 2021
@apelisse apelisse force-pushed the add-subresource-managedfields branch from 9025813 to d3852aa Compare April 16, 2021 15:48
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2021
@apelisse
Copy link
Member Author

Fixed gofmt

@jpbetz jpbetz mentioned this pull request Apr 16, 2021
Merged
@lavalamp
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2021
nodo and others added 3 commits April 16, 2021 14:13
@nodo @apelisse
Add "subresource" field to ManagedFieldEntry
862d256 
This field is useful to namespace the managed field entries of a
subresource and differentiate them from the ones of the main resource.
@nodo @apelisse
Generated code
93dffdc
@apelisse
fieldmanager: Comment test broken by status being separated from main…
e477c31 
… resource
@apelisse apelisse force-pushed the add-subresource-managedfields branch from d3852aa to e477c31 Compare April 16, 2021 21:26
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2021
@lavalamp
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2021
@jpbetz
Copy link
Contributor

jpbetz commented Apr 16, 2021

eviction v1 was introduced on master, I think this needs to be rebased to pick it up

@apelisse
Copy link
Member Author

/retest

@apelisse
Copy link
Member Author

I fixed it already I THINK

@apelisse
Copy link
Member Author

apelisse commented Apr 17, 2021 via email

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

2 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 0f1d105 into kubernetes:master Apr 17, 2021
@julz julz mentioned this pull request Aug 16, 2021
Closed
@Samze Samze mentioned this pull request Feb 11, 2022
Closed
Samze added a commit to Samze/service-bindings that referenced this pull request Feb 11, 2022
@Samze
Fix Webhook failures in k8s 1.22+
968ca36 
Kubernetes 1.22 added a new subresource field kubernetes/kubernetes#100970. The knative pkg which is used the webhook had an issue that was resolved here knative/serving#11448.

This change bumps the knative pkg dependency which includes the fix but keeps it pinned on the 0.22 release branch.

In addition it adds 1.22.6 to the k8s testing matrix in Github actions.

fixes vmware-tanzu#214
This was referenced Feb 11, 2022
Closed
Merged
Samze added a commit to Samze/service-bindings that referenced this pull request Feb 11, 2022
@Samze
Fix Webhook failures in k8s 1.22+
471a320 
Kubernetes 1.22 added a new subresource field kubernetes/kubernetes#100970. The knative pkg which is used the webhook had an issue that was resolved here knative/serving#11448.

This change bumps the knative pkg dependency which includes the fix but keeps it pinned on the 0.22 release branch.

In addition it adds 1.22.5 to the k8s testing matrix in Github actions.

fixes vmware-tanzu#214
Samze added a commit to Samze/service-bindings that referenced this pull request Feb 14, 2022
@Samze
Fix Webhook failures in k8s 1.22+
e4100c9 
Kubernetes 1.22 added a new subresource field kubernetes/kubernetes#100970. The knative pkg which is used the webhook had an issue that was resolved here knative/serving#11448.

This change bumps the knative pkg dependency which includes the fix but keeps it pinned on the 0.22 release branch.

fixes vmware-tanzu#214
Samze added a commit to Samze/service-bindings that referenced this pull request Feb 14, 2022
@Samze
Fix Webhook failures in k8s 1.22+
96f8c33 
Kubernetes 1.22 added a new subresource field kubernetes/kubernetes#100970. The knative pkg which is used the webhook had an issue that was resolved here knative/serving#11448.

This change bumps the knative pkg dependency which includes the fix but keeps it pinned on the 0.22 release branch.

In addition it adds 1.22.5 to the k8s testing matrix in Github actions.

fixes vmware-tanzu#214
rashedkvm pushed a commit to vmware-tanzu/servicebinding that referenced this pull request Feb 14, 2022
@Samze
Fix Webhook failures in k8s 1.22+ (#216)
2386e29 
Kubernetes 1.22 added a new subresource field kubernetes/kubernetes#100970. The knative pkg which is used the webhook had an issue that was resolved here knative/serving#11448.

This change bumps the knative pkg dependency which includes the fix but keeps it pinned on the 0.22 release branch.

In addition it adds 1.22.5 to the k8s testing matrix in Github actions.

fixes #214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp lavalamp left review comments

@jpbetz jpbetz Awaiting requested review from jpbetz

@kwiesmueller kwiesmueller Awaiting requested review from kwiesmueller

Assignees

@lavalamp lavalamp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/code-generation area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@apelisse @fejta-bot @k8s-ci-robot @lavalamp @jpbetz @nodo