-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Webhook failures in k8s 1.22+ #216
Conversation
968ca36
to
471a320
Compare
Codecov Report
@@ Coverage Diff @@
## main #216 +/- ##
=======================================
Coverage 94.34% 94.34%
=======================================
Files 16 16
Lines 637 637
=======================================
Hits 601 601
Misses 25 25
Partials 11 11 Continue to review full report at Codecov.
|
@@ -10,5 +10,5 @@ require ( | |||
k8s.io/apimachinery v0.19.16 | |||
k8s.io/client-go v0.19.16 | |||
k8s.io/code-generator v0.19.16 | |||
knative.dev/pkg v0.0.0-20210331065221-952fdd90dbb0 // pin to branch release-0.22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the updated knative.dev/pkg@release-0.22 fixed the issue. Curious why is it pinned to an older version? Maybe worth testing with the latest knative.dev/pkg@release-1.2. I will update my sandbox with the latest and try using the samples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just verified knative.dev/pkg@release-1.2 has breaking changes. So the latest patch from knative.dev/pkg@release-0.22 is sufficient for now.
471a320
to
e4100c9
Compare
Kubernetes 1.22 added a new subresource field kubernetes/kubernetes#100970. The knative pkg which is used the webhook had an issue that was resolved here knative/serving#11448. This change bumps the knative pkg dependency which includes the fix but keeps it pinned on the 0.22 release branch. In addition it adds 1.22.5 to the k8s testing matrix in Github actions. fixes vmware-tanzu#214
e4100c9
to
96f8c33
Compare
Webook failures with service bindings - vmware-tanzu/servicebinding#216 - vmware-tanzu/servicebinding#214
* Set kind cluster version to 1.21.9 Webook failures with service bindings - vmware-tanzu/servicebinding#216 - vmware-tanzu/servicebinding#214 * kindest node 1.21.2 appears to be the latest version of k8s available for 1.21.x branch
What this PR does / why we need it
Kubernetes 1.22 added a new subresource field kubernetes/kubernetes#100970. The knative pkg which is used the webhook had an issue that was resolved here knative/serving#11448.
This change bumps the knative pkg dependency which includes the fix but keeps it pinned on the 0.22 release branch.
In addition it adds 1.22.5 to the k8s testing matrix in Github actions.
fixes #214
Describe testing done for PR
ko apply -f config/
with this change.k apply -f samples/spring-pet-clinic
Note
This bumps the knative pkg only two commits https://github.com/knative/pkg/commits/release-0.22 so should be a relatively low risk change.