Fix Webhook failures in k8s 1.22+ #215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubernetes 1.22 added a new subresource field kubernetes/kubernetes#100970. The knative pkg which is used the webhook had an issue that was resolved here knative/serving#11448. This change bumps the knative pkg dependency which includes the fix but keeps it pinned on the 0.22 release branch. In addition it adds 1.22.6 to the k8s testing matrix in Github actions. fixes vmware-tanzu#214
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Kubernetes 1.22 added a new subresource field kubernetes/kubernetes#100970. The knative pkg which is used the webhook had an issue that was resolved here knative/serving#11448.
This change bumps the knative pkg dependency which includes the fix but keeps it pinned on the 0.22 release branch.
In addition it adds 1.22.6 to the k8s testing matrix in Github actions.
fixes #214
Describe testing done for PR
ko apply -f config/with this change.k apply -f samples/spring-pet-clinicNote
This bumps the knative pkg only two commits https://github.com/knative/pkg/commits/release-0.22 so should be a relatively low risk change.