Create a duration metric for probes

[SergeyKanzhelev]

/kind feature
/sig node

As exec probe timeout bug was fixed, upgrade of k8s may lead to unexpected workload disruptions if the exec probe timeout is not corrected properly. Unfortunately there is no easy way today to guess which timeout should be set for the probe. The suggestion is to introduce a duration metric to allow customers to measure this time.

Likely here where other metrics are defined: /pkg/kubelet/prober/prober_manager.go

KEP: kubernetes/enhancements#1972

/assign @jackfrancis
/cc @matthyx

[k8s-ci-robot]

@SergeyKanzhelev: GitHub didn't allow me to assign the following users: jackfrancis.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/kind feature
/sig node

As exec probe timeout bug was fixed, upgrade of k8s may lead to unexpected workload disruptions if the exec probe timeout is not corrected properly. Unfortunately there is no easy way today to guess which timeout should be set for the probe. The suggestion is to introduce a duration metric to allow customers to measure this time.

Likely here where other metrics are defined: /pkg/kubelet/prober/prober_manager.go

KEP: kubernetes/enhancements#1972

/assign @jackfrancis
/cc @matthyx

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jackfrancis]

/assign

[cynepco3hahue]

/triage accepted

[jackfrancis]

See here for a prototype reference of a metric:

• https://github.com/kubernetes/kubernetes/pull/95429/files#diff-c3e7f724d1b0dcee40df80716ed57d90d2649710150fa92bf9822bdad35e0429

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[SergeyKanzhelev]

/remove-lifecycle stale

as @jackfrancis is working on it

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[jackfrancis]

/remove-lifecycle stale

#104484 is still in-progress

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[jackfrancis]

/remove-lifecycle stale

ditto previous comment