Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC for vulnerability scanning using snyk #101528

Closed
7 tasks done
navidshaikh opened this issue Apr 27, 2021 · 11 comments
Closed
7 tasks done

POC for vulnerability scanning using snyk #101528

navidshaikh opened this issue Apr 27, 2021 · 11 comments
Assignees
Labels
area/code-organization Issues or PRs related to kubernetes code organization kind/feature Categorizes issue or PR as related to a new feature. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@navidshaikh
Copy link
Member

navidshaikh commented Apr 27, 2021

What would you like to be added:

A prow CI job to do vulnerability scanning for k/k dependencies using snyk.

Why is this needed:

Kubernetes has a very large number of golang library dependencies. While there is some work to track and ensure license compatability, there is little to know work done to track vulnerabilities in these library dependencies.

ref kubernetes/community#2992


This issue is to track doing a PoC for vulnerability scanning of k/k dependencies using snyk CLI.

The proposal is to create an optional prow CI job which runs snyk scan against k/k master.

This requires:

Just to be clear, All this is stuff we would do BEFORE a release. We are not talking about scanning containers here, just sanity check of dependencies that we pull in.

cc: @dims @nikhita @PushkarJ @spiffxp @nikhita

@navidshaikh navidshaikh added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 27, 2021
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 27, 2021
@navidshaikh
Copy link
Member Author

/area code-organization
/sig architecture

@k8s-ci-robot k8s-ci-robot added area/code-organization Issues or PRs related to kubernetes code organization sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 27, 2021
@spiffxp
Copy link
Member

spiffxp commented May 18, 2021

/assign

@navidshaikh
Copy link
Member Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 2, 2021
@navidshaikh
Copy link
Member Author

snyk scan continuous job is running at 6h interval, see https://testgrid.k8s.io/sig-security-snyk-scan#ci-kubernetes-snyk-master

result can be seen in each job artifacts https://gcsweb.k8s.io/gcs/kubernetes-jenkins/logs/ci-kubernetes-snyk-master/1405787379716853760/artifacts/

next:

  • add docs and communicate

any suggestion about where the docs should reside ?

@PushkarJ
Copy link
Member

PushkarJ commented Jun 18, 2021

Hey @navidshaikh Have been talking about location for docs with @dims and @tabbysable

https://github.com/kubernetes/community/ under sig-security seems like a good place. I have a WIP fork for this as well. Should get something for review for you next week. Let me know what you think!

@navidshaikh
Copy link
Member Author

sounds good @PushkarJ, thanks!

@PushkarJ
Copy link
Member

Docs PR: kubernetes/community#5853

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 20, 2021
@navidshaikh
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 4, 2021
@navidshaikh
Copy link
Member Author

The docs PR is merged kubernetes/sig-security#16, completes the checklist.

Thanks everyone for their contributions!

/close

@k8s-ci-robot
Copy link
Contributor

@navidshaikh: Closing this issue.

In response to this:

The docs PR is merged kubernetes/sig-security#16, completes the checklist.

Thanks everyone for their contributions!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/code-organization Issues or PRs related to kubernetes code organization kind/feature Categorizes issue or PR as related to a new feature. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

5 participants