Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pods with Shutdown status confuse users of graceful node shutdown feature #102820

Closed
SergeyKanzhelev opened this issue Jun 11, 2021 · 5 comments · Fixed by #102840
Closed

Pods with Shutdown status confuse users of graceful node shutdown feature #102820

SergeyKanzhelev opened this issue Jun 11, 2021 · 5 comments · Fixed by #102840
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@SergeyKanzhelev
Copy link
Member

What happened:

When using Graceful Node Shutdown feature, status and reason of "shutdown" pod are confusing for users. See kubernetes/website#28235 where I attempt to address this confusion by documenting the behavior.

However, it would be great to improve messages. Perhaps the following renaming:

Status:         Failed. --------------------------------> Same
Reason:         Shutdown ----------------------------> Terminated 
Message:        Node is shutting, evicting pods ------> Pod was terminated in response to node shutdown.

Reason "Shutdown" is confusing because it may appear as a process of shutting down. Better message will also be useful.

What you expected to happen:

Reason and Message changed for pods terminated in response to Node shutdown.

How to reproduce it (as minimally and precisely as possible):

Shutdown the node and observer the pod status.

Anything else we need to know?:

KEP: kubernetes/enhancements#2000
/cc @bobbypage
/sig node
/help
/good-first-issue

Environment:

  • Kubernetes version (use kubectl version): 1.19+ (with feature enabled)
@SergeyKanzhelev SergeyKanzhelev added the kind/bug Categorizes issue or PR as related to a bug. label Jun 11, 2021
@k8s-ci-robot
Copy link
Contributor

@SergeyKanzhelev:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

What happened:

When using Graceful Node Shutdown feature, status and reason of "shutdown" pod are confusing for users. See kubernetes/website#28235 where I attempt to address this confusion by documenting the behavior.

However, it would be great to improve messages. Perhaps the following renaming:

Status:         Failed. --------------------------------> Same
Reason:         Shutdown ----------------------------> Terminated 
Message:        Node is shutting, evicting pods ------> Pod was terminated in response to node shutdown.

Reason "Shutdown" is confusing because it may appear as a process of shutting down. Better message will also be useful.

What you expected to happen:

Reason and Message changed for pods terminated in response to Node shutdown.

How to reproduce it (as minimally and precisely as possible):

Shutdown the node and observer the pod status.

Anything else we need to know?:

KEP: kubernetes/enhancements#2000
/cc @bobbypage
/sig node
/help
/good-first-issue

Environment:

  • Kubernetes version (use kubectl version): 1.19+ (with feature enabled)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 11, 2021
@k8s-ci-robot
Copy link
Contributor

@SergeyKanzhelev: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 11, 2021
@ehashman
Copy link
Member

/cc @rphillips @wgahnagl

@novahe
Copy link
Contributor

novahe commented Jun 12, 2021

/assign

@Hanvans
Copy link

Hanvans commented Jun 15, 2021

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants