client-go: cannot create/update resource with server-side apply on client-go fake clientset

[sanposhiho]

Hello team.

What happened:

https://github.com/kubernetes/client-go/blob/ac207faedfb64acd5b99a2fb309b7044918b4dda/kubernetes/typed/core/v1/fake/fake_node.go#L138-L157

FakeNodes has Apply method, but we cannot create/update resource with server-side apply with this method.
And creating new resource and updating exist resource have different error message.

# create new resource
 nodes "nodename" not found

# update exist resource
PatchType is not supported 

What you expected to happen:

(1) support ApplyPatchType or (2) creating new resource makes the same error as updating (= PatchType is not supported)

How to reproduce it (as minimally and precisely as possible):

apply resource with fake clientset

Anything else we need to know?:

Environment:

• client-go version: latest

[sanposhiho]

I'd like to take this issue
/assign

[neolit123]

/sig api-machinery

[sanposhiho]

I have no good idea to implement server-side apply logic on PatchActionImpl to support ApplyPatchType 😢
For now, I changed the error message on creating new resource with serverside apply. #103821

[fedebongio]

/cc @apelisse @leilajal @kwiesmueller
/triage accepted

[apelisse]

We've discussed that with @jpbetz before. Not sure that's something we want to do.

[jpbetz]

We've discussed that with Joe Betz before. Not sure that's something we want to do.

See our earlier discussion about this and the doc we wrote on the topic for more detail.

[sanposhiho]

Hello.
OK, So this issue is duplicated with #99953. I'll close it with #103821, thanks

[howardjohn]

I don't think #103821 closes this since it just makes the error better.

[sanposhiho]

Hi @howardjohn
We can see two problems in this issue.

• fake clientset doesn't support server-side apply
• for the current situation, error message is not appropriate because user cannot know fake clientset doesn't support server-side apply from error message.

And the first one is duplicated with #99953. So I think it is ok to close this issue with #103821, because the PR will fix the second one.

[sanposhiho]

Aha, #99953 was closed because of non-update. I'll reopen it.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[sanposhiho]

/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.