Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KEP-2400] Add swap memory to the Kubelet stats API #105021

Closed
ehashman opened this issue Sep 14, 2021 · 20 comments
Closed

[KEP-2400] Add swap memory to the Kubelet stats API #105021

ehashman opened this issue Sep 14, 2021 · 20 comments
Assignees
@yxxhero @mengjiao-liu
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Node Swap Beta

Comments

@ehashman
Copy link
Member

What would you like to be added:

Add swap memory to the Kubelet stats API so that we have metrics on swap utilization.

  • Code changes
  • Add e2e coverage

Why is this needed:

See https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2400-node-swap#beta
@ehashman ehashman added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 14, 2021
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 14, 2021
@ehashman ehashman mentioned this issue Sep 14, 2021
Open
44 tasks
@ehashman
Copy link
Member Author

/sig node instrumentation
/triage accepted
/priority important-soon
/cc @bobbypage @dashpole

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 14, 2021
@mengjiao-liu
Copy link
Member

mengjiao-liu commented Sep 15, 2021 •
edited

I want to work on it.
/assign

@yxxhero
Copy link
Member

yxxhero commented Sep 16, 2021

@mengjiao-liu May I be a backup? Thansk very much. wo can work together for this KEP.
/assign

@mengjiao-liu
Copy link
Member

@mengjiao-liu May I be a backup? Thansk very much. wo can work together for this KEP.
/assign

Of course, very happy to work with you.

@yxxhero yxxhero mentioned this issue Oct 3, 2021
Closed
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 15, 2021
@pacoxu
Copy link
Member

pacoxu commented Dec 15, 2021

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 15, 2021
@ehashman ehashman added this to To do in Node Swap Beta Jan 18, 2022
@ehashman
Copy link
Member Author

/unassign @yxxhero @mengjiao-liu
/milestone v1.24

Clearing assignees for this release as there are no attached PRs, please reassign if you have the bandwidth to complete this.

@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 18, 2022
@mmiranda96
Copy link
Contributor

I'm interested in working on this for 1.24
/assign

@mengjiao-liu
Copy link
Member

mengjiao-liu commented Jan 19, 2022 •
edited

Still working on this.
/assign @yxxhero @mengjiao-liu

@mengjiao-liu
Copy link
Member

/unassign @mmiranda96

@yxxhero yxxhero mentioned this issue Jan 19, 2022
Closed
@ehashman
Copy link
Member Author

ack, thank you!

@helayoty
Copy link
Member

@ehashman @mengjiao-liu 👋 the release 1.24 bug triage shadow. Does this issue still target release 1.24?

@ehashman
Copy link
Member Author

/milestone clear
per kubernetes/enhancements#2400 (comment)

PR is up and was reviewed but hasn't been updated.

@k8s-ci-robot k8s-ci-robot removed this from the v1.24 milestone Mar 28, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 26, 2022
@vaibhav2107
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 29, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 27, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 27, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 26, 2022
@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Node Swap Beta automation moved this from To do to Done Nov 26, 2022
@mansikulkarni96 mansikulkarni96 mentioned this issue May 2, 2023
Closed
@iholder101
Copy link
Contributor

Issue is inactive and outdated. Please use this one instead: #119425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yxxhero yxxhero

@mengjiao-liu mengjiao-liu

Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Node Swap Beta
  
Done
Milestone
No milestone
10 participants
@pacoxu @ehashman @yxxhero @mmiranda96 @k8s-ci-robot @helayoty @mengjiao-liu @k8s-triage-robot @iholder101 @vaibhav2107