Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GA feature gates in 1.28 about network #117237

Merged
merged 1 commit into from Apr 28, 2023
Merged

Remove GA feature gates in 1.28 about network #117237

merged 1 commit into from Apr 28, 2023

Conversation

yulng
Copy link
Contributor

@yulng yulng commented Apr 12, 2023 •
edited by thockin

remove in 1.28 about network
/kind cleanup

remove GAed feature gates: MixedProtocolLBService, ServiceInternalTrafficPolicy, ServiceIPStaticSubrange, and EndpointSliceTerminatingCondition

xref kubernetes/enhancements#1435
xref kubernetes/enhancements#2086
xref kubernetes/enhancements#3070
xref kubernetes/enhancements#1672

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 12, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @yulng. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Apr 12, 2023
@aojea
Copy link
Member

aojea commented Apr 12, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 12, 2023
@Iceber
Copy link
Member

Iceber commented Apr 13, 2023

Maybe it would be better to change commit message and pr title to remove GA feature gates in 1.28 about network

@yulng yulng changed the title remove in 1.28 about network Remove GA feature gates in 1.28 about network Apr 13, 2023
@yulng
Copy link
Contributor Author

yulng commented Apr 13, 2023

Maybe it would be better to change commit message and pr title to remove GA feature gates in 1.28 about network

ok,done

@yulng
Copy link
Contributor Author

yulng commented Apr 13, 2023

/retest

@yulng
Copy link
Contributor Author

yulng commented Apr 15, 2023

ping @lavalamp @thockin

@pacoxu
Copy link
Member

pacoxu commented Apr 24, 2023 •
edited

/sig network

@k8s-ci-robot
Copy link
Contributor

@pacoxu: /release-note-edit must be used with a single release note block.

In response to this:

/sig network
/release-note-edit

remove GAed feature gates: MixedProtocolLBService, ServiceInternalTrafficPolicy, ServiceIPStaticSubrange and EndpointSliceTerminatingCondition

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 24, 2023
@pacoxu
Copy link
Member

pacoxu commented Apr 24, 2023

/release-note-edit

remove GAed feature gates: MixedProtocolLBService, ServiceInternalTrafficPolicy, ServiceIPStaticSubrange, and EndpointSliceTerminatingCondition

@k8s-ci-robot
Copy link
Contributor

@pacoxu: /release-note-edit must be used with a release note block.

In response to this:

/release-note-edit

remove GAed feature gates: MixedProtocolLBService, ServiceInternalTrafficPolicy, ServiceIPStaticSubrange, and EndpointSliceTerminatingCondition

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 24, 2023
@thockin
Copy link
Member

thockin commented Apr 27, 2023

Let me know if you can't figure how to remove the merge commit :)

@yulng
remove GA feature gates in 1.28 about network
0dbeff4 
Signed-off-by: yulng <wei.yang@daocloud.io>
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Apr 28, 2023
@yulng
Copy link
Contributor Author

yulng commented Apr 28, 2023

Let me know if you can't figure how to remove the merge commit :)

I haven't had time to read it before. Can you see if the changes are correct now
Thanks😄

@pacoxu
Copy link
Member

pacoxu commented Apr 28, 2023

/priority important-soon
/triage accepted
/lgtm

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 28, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 794bc4e1aeb70497a6f179f4aacc3a621034e904

thockin
thockin reviewed Apr 28, 2023
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin, yulng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7077491 into kubernetes:master Apr 28, 2023
11 of 13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Apr 28, 2023
@yulng yulng mentioned this pull request May 4, 2023
Closed
9 tasks
@aojea aojea mentioned this pull request May 8, 2023
Merged
@aojea
Copy link
Member

aojea commented May 8, 2023

@yulng we forgot to remove the tags from the e2e tests, can you please check the e2e tests that still have the tag associated feature gate and remove it, like I did in #117864?

@robscott robscott mentioned this pull request Dec 13, 2023
Merged
@honcao honcao mentioned this pull request Jan 3, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@pacoxu pacoxu

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yulng @k8s-ci-robot @aojea @Iceber @pacoxu @thockin