Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make docker-email optional when create registry secret #41727

Closed
gyliu513 opened this issue Feb 19, 2017 · 6 comments
Closed

Make docker-email optional when create registry secret #41727

gyliu513 opened this issue Feb 19, 2017 · 6 comments
Assignees
@smarterclayton

Comments

@gyliu513
Copy link
Contributor

Is this a request for help? (If yes, you should use our troubleshooting guide and community support channels, see http://kubernetes.io/docs/troubleshooting/.):

What keywords did you search in Kubernetes issues before filing this one? (If you have found any duplicates, you should instead reply there.):

Is this a BUG REPORT or FEATURE REQUEST? (choose one):

Kubernetes version (use kubectl version):

Environment:

  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:

What happened:
When I create a docker registry secret, the docker-email is also a MUST, I think we should make this parameter as optional as there is no need always put docker-email when creating a docker registry secret.

kubectl create secret docker-registry regsecret --docker-username=<your-name> --docker-password=<your-pword> --docker-email=<your-email>

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know:
@smarterclayton smarterclayton self-assigned this Feb 27, 2017
@smarterclayton smarterclayton mentioned this issue Feb 27, 2017
Merged
@smarterclayton
Copy link
Contributor

Agree it should not be required

k8s-github-robot pushed a commit that referenced this issue Mar 1, 2017
Merge pull request #42191 from smarterclayton/dockercfg_secret
50943d1 
Automatic merge from submit-queue (batch tested with PRs 42316, 41618, 42201, 42113, 42191)

Make 'docker-email' optional on dockercfg secrets

It is not required for most username/password registries.

Fixes #41727
@AaronFriel
Copy link

Did this change get reverted? I do not see --docker-email as optional on stable.

@apri12
Copy link

apri12 commented Dec 22, 2017

I feel that this code should be changed because "--docker-email flag" is no longer required.
50943d1#diff-5cbf8d0bccc129f03f4a6c5eebe29bdcR172

@bendrucker bendrucker mentioned this issue Mar 1, 2018
Merged
k8s-github-robot pushed a commit that referenced this issue Mar 21, 2018
Merge pull request #60602 from bendrucker/docker-registry-email-optional
808545a 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

remove docker-email from required args for "create secret docker-registry"

Completes #42191

While that removed `docker-email` as required from the generator, the CLI still asserts the presence of the argument resulting in "error: flag docker-email is required" when `--docker-email` is omitted from a `kubectl create secret docker-registry` call.

Comments on the original issue (#41727) note that this change is still needed to accomplish the original intent.
@372046933
Copy link

error: flag docker-email is required.
On kubenetes 1.10.3, the above error message still exists

@JakeKo
Copy link

JakeKo commented Jul 27, 2018

The --docker-email field is still required. This is very frustrating as docker login does not require an email but Kubernetes does? Is there a good reason for this?

@mmacy mmacy mentioned this issue Aug 7, 2018
Closed
@srudin
Copy link

srudin commented May 9, 2019

Why is this closed? As far as I can see it is still required?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smarterclayton smarterclayton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@AaronFriel @smarterclayton @372046933 @srudin @gyliu513 @JakeKo @apri12