Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status field means different things for different controllers #42410

Closed
0xmichalis opened this issue Mar 2, 2017 · 4 comments
Closed

Status field means different things for different controllers #42410

0xmichalis opened this issue Mar 2, 2017 · 4 comments
Assignees
@kow3ns
Labels
area/stateful-apps kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/apps Categorizes an issue or PR as relevant to SIG Apps.
Milestone
v1.8

Comments

@0xmichalis
Copy link
Contributor

0xmichalis commented Mar 2, 2017 •
edited
Loading

status.replicas is used by ReplicaSets, ReplicationControllers, Deployments, DaemonSets (CurrentNumberScheduled), and StatefulSets. For all of the controllers apart from StatefulSets, it means the number of pods that have been created. For StatefulSets, it means the pods that are ready. We should fix this. StatefulSets need all the rest of the status fields anyway - ReadyReplicas, AvailableReplicas, and once updates are done, UpdatedReplicas.

@kubernetes/sig-apps-api-reviews @kow3ns
@0xmichalis 0xmichalis added area/stateful-apps kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Mar 2, 2017
@0xmichalis 0xmichalis added this to the v1.7 milestone Mar 2, 2017
@0xmichalis 0xmichalis mentioned this issue Mar 2, 2017
Merged
@0xmichalis
Copy link
Contributor Author

Ref: #37563

@bgrant0607 bgrant0607 mentioned this issue Mar 10, 2017
Closed
@0xmichalis 0xmichalis mentioned this issue May 21, 2017
Merged
@0xmichalis
Copy link
Contributor Author

Should be addressed in kubernetes/community#503

@dchen1107 dchen1107 modified the milestones: v1.8, v1.7 Jun 14, 2017
@dchen1107
Copy link
Member

This requires API-Change, which should be punt to next release since we are at code freeze stage already. cc/ @erictune

@0xmichalis
Copy link
Contributor Author

This is fixed in 1.7 - the status.replicas field in statefulsets is aligned with the respective field in the rest of the workload controllers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kow3ns kow3ns

Labels
area/stateful-apps kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/apps Categorizes an issue or PR as relevant to SIG Apps.
Projects
None yet
Milestone
v1.8
Development

No branches or pull requests
3 participants
@0xmichalis @dchen1107 @kow3ns