Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pod suffix is b0110ck5 #49543

Closed
jamesawebb opened this issue Jul 25, 2017 · 6 comments · Fixed by #50070
Closed

Pod suffix is b0110ck5 #49543

jamesawebb opened this issue Jul 25, 2017 · 6 comments · Fixed by #50070
Assignees
@jamesawebb
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@jamesawebb
Copy link

/kind feature

What happened:

In playing with the nginx ingress controller deployment, I noticed the following pod name:
nginx-ingress-controller-1449474453-c0ck5
I figure we should possibly put something in place to prevent accidental l33t profanity ;-).

What you expected to happen:

The following pod name:
nginx-ingress-controller-1449474453-r0ck5
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 25, 2017
@k8s-github-robot
Copy link

@jamesawebb1
There are no sig labels on this issue. Please add a sig label by:

  1. mentioning a sig: @kubernetes/sig-<group-name>-<group-suffix>
    e.g., @kubernetes/contributor-experience-<group-suffix> to notify the contributor experience sig, OR

  2. specifying the label manually: /sig <label>
    e.g., /sig scalability to apply the sig/scalability label

Note: Method 1 will trigger an email to the group. You can find the group list here and label list here.
The <group-suffix> in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals

@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jul 25, 2017
@jamesawebb
Copy link
Author

My first github (k8s) issue. I've no idea which SIG would cover this topic.

/sig product-management

@spiffxp
Copy link
Member

spiffxp commented Jul 26, 2017

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jul 26, 2017
@k8s-github-robot k8s-github-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jul 26, 2017
@mml mml self-assigned this Jul 31, 2017
@mml
Copy link
Contributor

mml commented Aug 2, 2017

Previously we removed vowels in #37225. We can 3xt3nd the idea with 0, 1 (can stand for I) and 3. @jamesawebb1 would you like to send a PR? If not, I can work on this.

@mml
Copy link
Contributor

mml commented Aug 2, 2017

/assign jamesawebb1

@mml mml removed their assignment Aug 2, 2017
@mml
Copy link
Contributor

mml commented Aug 2, 2017

@jamesawebb1 Reassign to me if you do not want to contribute a PR.

@dixudx dixudx mentioned this issue Aug 3, 2017
Merged
k8s-github-robot pushed a commit that referenced this issue Aug 4, 2017
Merge pull request #50070 from dixudx/remove_013_to_avoid_bad_words
704cc7f 
Automatic merge from submit-queue (batch tested with PRs 46685, 49863, 50098, 50070, 50096)

Remove 0,1,3 from rand.String to avoid 'bad words'

**What this PR does / why we need it**:

Remove 0,1,3 from the runes to prevent accidental bad words profanity

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #49543

**Special notes for your reviewer**:
/cc @mml  @jamesawebb1  @spiffxp 

**Release note**:

```release-note
Remove 0,1,3 from rand.String, to avoid 'bad words'
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesawebb jamesawebb

Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove 0,1,3 from rand.String to avoid 'bad words' dixudx/kubernetes
5 participants
@mml @spiffxp @k8s-github-robot @k8s-ci-robot @jamesawebb