Remove 0,1,3 from rand.String to avoid 'bad words'

[dixudx]

What this PR does / why we need it:

Remove 0,1,3 from the runes to prevent accidental bad words profanity

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #49543

Special notes for your reviewer:
/cc @mml @jamesawebb1 @spiffxp

Release note:

Remove 0,1,3 from rand.String, to avoid 'bad words'

[k8s-ci-robot]

@dixudx: GitHub didn't allow me to request PR reviews from the following users: jamesawebb1.

Note that only kubernetes members can review this PR, and authors cannot review their own PRs.

In response to this:

What this PR does / why we need it:

Remove 0,1,3 from the runes to prevent accidental bad words profanity

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #49543

Special notes for your reviewer:
/cc @mml @jamesawebb1 @spiffxp

Release note:

Remove 0,1,3 from rand.String, to avoid 'bad words'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Hi @dixudx. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[deads2k]

I feel like I should require a good story every time someone wants to remove items from the list. The "I was demo-ing to customer X and this one popped up" must be awesome.

[dixudx]

@deads2k Because it generated some offensive string like nginx-ingress-controller-1449474453-c0ck5.

[mml]

/lgtm

Thanks!

[mml]

/ok-to-test

[deads2k]

@deads2k Because it generated some offensive string like nginx-ingress-controller-1449474453-c0ck5.

Heh. That's an unlucky demo. :)

/approve

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, dixudx, mml

Associated issue: 49543

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

• pkg/controller/serviceaccount/OWNERS [deads2k]
• staging/src/k8s.io/apimachinery/pkg/OWNERS [deads2k]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[k8s-github-robot]

Automatic merge from submit-queue (batch tested with PRs 46685, 49863, 50098, 50070, 50096)

[tedyu]

@dixudx
Can you show me a bad string consisting of '3' ?

The reason I ask this question is that, according to BenchmarkRandomStringGeneration, addition of digit(s) would make the random number generator faster.

I agree about '0' and '1' being similar to 'o' and 'i'.
But I don't agree about '3'.

Thanks

[mml]

@tedyu see #49543 (comment)

[tedyu]

@mml
I don't see bad word example in that comment.
We should also be aware of performance implication w.r.t. removal of digits.

[liggitt]

I don't see bad word example in that comment.

"3xt3nd" was an example of how the number 3 makes words readable as english.

We should also be aware of performance implication w.r.t. removal of digits.

has that been demonstrated to be a problematic hotspot in a profile?

[2rs2ts]

Sorry to necro this. I was wondering if we should also remove 4, since that's often used as a substitute for A in leetspeak, in the same way that 0 subs for O, 1 for I, and 3 for E. I was going to open an issue about this instead, but it didn't seem like it fit into any of the issue categories (not a bug, there's no KEP for it, etc...)