Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows containers creation failed because of rslave mounts #60274

Closed
feiskyer opened this issue Feb 23, 2018 · 5 comments · Fixed by #60275
Closed

Windows containers creation failed because of rslave mounts #60274

feiskyer opened this issue Feb 23, 2018 · 5 comments · Fixed by #60275
Assignees
@feiskyer
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/windows Categorizes an issue or PR as relevant to SIG Windows.
Milestone
v1.10

Comments

@feiskyer
Copy link
Member

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

/kind feature

What happened:

Windows containers creation failed because of rslave mounts.

 Error: Error response from daemon: invalid bind mount spec "c:\\var\\lib\\kubelet\\pods\\a260a7c4-1852-11e8-bb1d-000d3a19c1da\\volumes\\kubernetes.io~secret\\default-token-rj7qv:c:/var/run/secrets/kubernetes.io/serviceaccount:ro,rslave": invalid volume specification: 'c:\var\lib\kubelet\pods\a260a7c4-1852-11e8-bb1d-000d3a19c1da\volumes\kubernetes.io~secret\default-token-rj7qv:c:\var\run\secrets\kubernetes.io\serviceaccount:ro,rslave'

What you expected to happen:

Windows containers don't support mount propagation, we should disable it for windows.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. kind/bug Categorizes issue or PR as related to a bug. labels Feb 23, 2018
@feiskyer feiskyer self-assigned this Feb 23, 2018
@feiskyer
Copy link
Member Author

/sig windows

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 23, 2018
@feiskyer feiskyer mentioned this issue Feb 23, 2018
Merged
@feiskyer feiskyer added this to the v1.10 milestone Feb 23, 2018
@feiskyer feiskyer added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Feb 23, 2018
@andyzhangx
Copy link
Member

@feiskyer What's your pod config for rslave mount?

@jdumars
Copy link
Member

jdumars commented Feb 23, 2018

@michmike if you agree with this as a blocker for 1.10, could you go ahead and add "approved-for-milestone" label to this, as well as status? That will help it stay in the milestone.

@michmike
Copy link
Contributor

/status approved-for-milestone

@jberkus jberkus mentioned this issue Feb 23, 2018
Closed
@feiskyer
Copy link
Member Author

@feiskyer What's your pod config for rslave mount?

@andyzhangx Any pods on Windows would meet same issue. It defaults to rslave now on master branch.

k8s-github-robot pushed a commit that referenced this issue Feb 24, 2018
Merge pull request #60275 from feiskyer/mount
af58729 
Automatic merge from submit-queue (batch tested with PRs 60054, 60202, 60219, 58090, 60275). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Disable mount propagation for windows containers

**What this PR does / why we need it**:

Windows containers don't support mount propagation. This PR disables it for windows containers.

Without this PR, windows containers creation would fail with error:

 Error: Error response from daemon: invalid bind mount spec "c:\\var\\lib\\kubelet\\pods\\a260a7c4-1852-11e8-bb1d-000d3a19c1da\\volumes\\kubernetes.io~secret\\default-token-rj7qv:c:/var/run/secrets/kubernetes.io/serviceaccount:ro,rslave": invalid volume specification: 'c:\var\lib\kubelet\pods\a260a7c4-1852-11e8-bb1d-000d3a19c1da\volumes\kubernetes.io~secret\default-token-rj7qv:c:\var\run\secrets\kubernetes.io\serviceaccount:ro,rslave'


**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #60274

**Special notes for your reviewer**:

**Release note**:

```release-note
Disable mount propagation for windows containers.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feiskyer feiskyer

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/windows Categorizes an issue or PR as relevant to SIG Windows.
Projects
None yet
Milestone
v1.10
Development

Successfully merging a pull request may close this issue.

Disable mount propagation for windows containers feiskyer/kubernetes
5 participants
@feiskyer @jdumars @andyzhangx @michmike @k8s-ci-robot