Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Istio addon images should be in gcr.io for scanning #61910

Closed
ostromart opened this issue Mar 29, 2018 · 2 comments
Closed

Istio addon images should be in gcr.io for scanning #61910

ostromart opened this issue Mar 29, 2018 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.

Comments

@ostromart
Copy link
Contributor

/kind bug

What happened:
#59378 added istio manifests to the kubernetes addons directory. There are several issues with the images in the yaml:

prom/statsd-exporter:v0.5.0
docker.io/prom/prometheus:v2.0.0
docker.io/openzipkin/zipkin:latest

If we want Istio to be considered a GKE Addon, these should all be mirrored to gcr.io so that we can continuously scan them for known vulnerabilities.
As a side note, the image should be fully specified (e.g. "docker.io/..." or "gcr.io/...").
The zipkin image should specify a version, so we don't get arbitrarily broken.

What you expected to happen:
Images should conform to guidelines above.

How to reproduce it (as minimally and precisely as possible):
Inspect the yaml files.

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version): v.1.10.0+
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. kind/bug Categorizes issue or PR as related to a bug. labels Mar 29, 2018
@ostromart
Copy link
Contributor Author

Originally raised by @cjcullen

@ostromart ostromart mentioned this issue Mar 29, 2018
Merged
@ostromart
Copy link
Contributor Author

/sig cluster-lifecycle

@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 29, 2018
k8s-github-robot pushed a commit that referenced this issue Apr 17, 2018
Merge pull request #61911 from ostromart/istio_update_version
28f9356 
Automatic merge from submit-queue (batch tested with PRs 57224, 61911). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Update Istio addon to 0.6.0 and mirror images in gcr

**What this PR does / why we need it:**
PR addresses two issues:
1. Update Istio addon version to latest stable 0.6.0 (required for e2e test integration).
2. Mirror images in gcr.io for security scanning, since this is an addon.

Fixes #61910 

**Release note**:
```release-note
NONE
```
@ostromart ostromart mentioned this issue Apr 18, 2018
Merged
k8s-github-robot pushed a commit that referenced this issue Apr 26, 2018
Merge pull request #62813 from ostromart/automated-cherry-pick-of-#61…
77db0fb 
…911-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #61911 upstream release 1.10

**What this PR does / why we need it:**
PR addresses two issues:
1. Update Istio addon version to latest stable 0.6.0 (required for e2e test integration).
2. Mirror images in gcr.io for security scanning, since this is an addon.

Fixes #61910 

**Release note**:
```release-note
Update version of Istio addon from 0.5.1 to 0.6.0.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@k8s-ci-robot @ostromart