Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hostpath.type as DirectoryOrCreate does not work on windows #62121

Closed
andyzhangx opened this issue Apr 4, 2018 · 2 comments · Fixed by #62154
Closed

hostpath.type as DirectoryOrCreate does not work on windows #62121

andyzhangx opened this issue Apr 4, 2018 · 2 comments · Fixed by #62154
Assignees
@andyzhangx
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/windows Categorizes an issue or PR as relevant to SIG Windows.

Comments

@andyzhangx
Copy link
Member

Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug

Uncomment only one, leave it on its own line:

/kind bug
/kind feature

What happened:
hostpath.type as DirectoryOrCreate does not work on windows, there will be mount failed error

---
apiVersion: v1
kind: Pod
metadata:
  name: aspnet-hostpath
spec:
  containers:
  - image: microsoft/aspnet
    name: aspnet-hostpath
    volumeMounts:
    - name: test-volume
      mountPath: '/azure'
  nodeSelector:
    beta.kubernetes.io/os: windows
  volumes:
  - name: test-volume
    hostPath:
      path: 'c:\var\lib\kublet\test'
      type: DirectoryOrCreate

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version): v1.11
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:

/sig storage
/sig windows
/assign
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/windows Categorizes an issue or PR as relevant to SIG Windows. labels Apr 4, 2018
@andyzhangx andyzhangx mentioned this issue Apr 4, 2018
Closed
@dixudx dixudx mentioned this issue Apr 5, 2018
Merged
@dixudx
Copy link
Member

dixudx commented Apr 5, 2018

@andyzhangx I submitted another alternative PR to fix this issue. PTAL #62154

detiber pushed a commit to detiber/kubernetes that referenced this issue Apr 10, 2018
Merge pull request kubernetes#62154 from dixudx/fix-hostpath-type-win…
77d18db 
…dows

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

fix incompatible file type checking on Windows

**What this PR does / why we need it**:

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes kubernetes#62121

**Special notes for your reviewer**:
/cc @msau42 @jsafrane 
/assign @andyzhangx 

**Release note**:

```release-note
fix incompatible file type checking on Windows
```
@andyzhangx andyzhangx mentioned this issue Sep 14, 2018
Closed
@andyzhangx
Copy link
Member Author

This issue is fixed in v1.9.7, v1.10.2, v1.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andyzhangx andyzhangx

Labels
kind/bug Categorizes issue or PR as related to a bug. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/windows Categorizes an issue or PR as relevant to SIG Windows.
Projects
None yet
Milestone
No milestone
3 participants
@andyzhangx @dixudx @k8s-ci-robot