[1.11] GC: remove CRD and APIService from ignored resources

[nikhita]

Fixes partially #65818

This cherry-picks the GC bits for CRD and APIService from #65856. See #65856 (comment) for more details.

Release note:

The garbage collector now supports CustomResourceDefinitions and APIServices.

[nikhita]

/sig api-machinery
/kind bug
/priority important-soon

/assign @liggitt
/cc @deads2k @sttts

/assign @foxish
for cherry-pick approval

[liggitt]

/lgtm
/milestone v1.11
/status approved-for-milestone

[nikhita]

/assign @caesarxuchao
for approval

[xmudrii]

@nikhita Do we need to cherry pick it to v1.10 as it's affected too?

/lgtm

[k8s-ci-robot]

@xmudrii: changing LGTM is restricted to assignees, and only kubernetes/kubernetes repo collaborators may be assigned issues.

In response to this:

@nikhita Do we need to cherry pick it to v1.10 as it's affected too?

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[liggitt]

@nikhita Do we need to cherry pick it to v1.10 as it's affected too?

/lgtm

yes, these should never have been included.

[nikhita]

I think this should be cherry-picked to 1.9 too. (sending a PR for both)

[xmudrii]

@liggitt Can I try it? @nikhita Do you want?

[nikhita]

@liggitt Can I try it? @nikhita Do you want?

Feel free to send a PR. :)

[xmudrii]

@nikhita There's also pkg/quota/install/registry.go. Is it needed to remove CRDs and APIServices from that one too?

Also, is removal needed for other resources from #65856?

Feel free to send a PR. :)

Okay, in a moment. :)

[liggitt]

There's also pkg/quota/install/registry.go? Is it needed to remove CRDs and APIServices from that one too?

that's irrelevant, since they're not namespaced objects

[xmudrii]

@liggitt @nikhita Okay, sounds good to me.

Created #65916, I need /ok-to-test and cherry-pick approval.

[nikhita]

Created #65918 against 1.9 since we maintain three releases at a time (1.11, 1.10 and 1.9 right now).

[nikhita]

since this has kube-controller-manager changes:

/assign @deads2k
for approval

[deads2k]

/approve

[liggitt]

/lgtm

[k8s-github-robot]

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@caesarxuchao @deads2k @foxish @liggitt @nikhita

Pull Request Labels

• sig/api-machinery: Pull Request will be escalated to these SIGs if needed.
• priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
• kind/bug: Fixes a bug discovered during the current release.

Help

• Additional instructions
• Commands for setting labels

[k8s-github-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[caesarxuchao]

Sorry I was ooo last week.

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, deads2k, liggitt, nikhita, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cmd/kube-controller-manager/OWNERS [deads2k]
• pkg/controller/garbagecollector/OWNERS [caesarxuchao,deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-github-robot]

Automatic merge from submit-queue.