[1.9] GC: remove CRD and APIService from ignored resources #65918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-github-robot
added
the
do-not-merge/cherry-pick-not-approved
k8s-ci-robot
added
sig/api-machinery
|
/cc @xmudrii |
|
@nikhita: GitHub didn't allow me to request PR reviews from the following users: xmudrii. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@xmudrii: changing LGTM is restricted to assignees, and only kubernetes/kubernetes repo collaborators may be assigned issues. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: caesarxuchao, deads2k, nikhita, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
|
/retest
…On Wed, Jul 11, 2018 at 3:17 PM k8s-ci-robot ***@***.***> wrote:
@nikhita <https://github.com/nikhita>: The following test *failed*, say
/retest to rerun them all:
Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws 04f2d7f
<04f2d7f>
link
<https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/65918/pull-kubernetes-e2e-kops-aws/96784/> /test
pull-kubernetes-e2e-kops-aws
Full PR test history <https://k8s-gubernator.appspot.com/pr/65918>. Your
PR dashboard <https://k8s-gubernator.appspot.com/pr/nikhita>. Please help
us cut down on flakes by linking to
<https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when
you hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#65918 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APXA0I2yTfeJ_j5-E58KfgURqCwboSb3ks5uFcnMgaJpZM4VF10S>
.
|
|
/retest
…On Wed 11 Jul, 2018, 4:03 PM k8s-ci-robot, ***@***.***> wrote:
@nikhita <https://github.com/nikhita>: The following test *failed*, say
/retest to rerun them all:
Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws 04f2d7f
<04f2d7f>
link
<https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/65918/pull-kubernetes-e2e-kops-aws/96796/> /test
pull-kubernetes-e2e-kops-aws
Full PR test history <https://k8s-gubernator.appspot.com/pr/65918>. Your
PR dashboard <https://k8s-gubernator.appspot.com/pr/nikhita>. Please help
us cut down on flakes by linking to
<https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when
you hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#65918 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APXA0A3FNr9IuQ7E8utZdOXLSZWp9KUXks5uFdSUgaJpZM4VF10S>
.
|
|
/retest |
mbohlool
added
cherry-pick-approved
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65818
This cherry-picks the GC bits for CRD and APIService from #65856. See #65856 (comment) for more details.
Release note: