Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only need to ignore resources that match discovery conditions #65856

Merged
merged 1 commit into from
Jul 6, 2018
Merged

only need to ignore resources that match discovery conditions #65856

merged 1 commit into from
Jul 6, 2018

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jul 5, 2018 •
edited
Loading

GC and quota controllers ignore resources that are too expensive to manage. In kube this is only events. The incompatible resources should now be excluded on the basis of discovery. We should actually reflect that in the RESTStorage (done for GC for events) and discovery too.

@liggitt
@kubernetes/sig-api-machinery-bugs

NONE

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 5, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2018
@deads2k deads2k mentioned this pull request Jul 5, 2018
Closed
xmudrii
xmudrii approved these changes Jul 5, 2018
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems to fix the issue #65818

/lgtm

@k8s-ci-robot
Copy link
Contributor

@xmudrii: changing LGTM is restricted to assignees, and only kubernetes/kubernetes repo collaborators may be assigned issues.

In response to this:

That seems to fix the issue #65818

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 5, 2018
liggitt
liggitt reviewed Jul 5, 2018
View reviewed changes
pkg/quota/install/registry.go Outdated
{Group: "", Resource: "events"}: {},
{Group: "authentication.k8s.io", Resource: "tokenreviews"}: {},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this prevent creation of these before quota objects sync?

pkg/controller/garbagecollector/graph_builder.go
@@ -337,17 +337,7 @@ func (gb *GraphBuilder) Run(stopCh <-chan struct{}) {
}

var ignoredResources = map[schema.GroupResource]struct{}{
{Group: "extensions", Resource: "replicationcontrollers"}: {},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these not listable/watchable?

@liggitt
Copy link
Member

liggitt commented Jul 6, 2018

/lgtm

I think the change to CRD/APIService for GC should be picked to 1.11

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, liggitt, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nikhita
Copy link
Member

nikhita commented Jul 6, 2018

I think the change to CRD/APIService for GC should be picked to 1.11

I'll do it. 👍

@nikhita nikhita mentioned this pull request Jul 6, 2018
Merged
@nikhita
Copy link
Member

nikhita commented Jul 6, 2018

I think the change to CRD/APIService for GC should be picked to 1.11

#65915

@xmudrii xmudrii mentioned this pull request Jul 6, 2018
Merged
@nikhita nikhita mentioned this pull request Jul 6, 2018
Merged
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 65897, 65909, 65856, 65815). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit d1608c2 into kubernetes:master Jul 6, 2018
@fedebongio
Copy link
Contributor

/cc @roycaihw

k8s-github-robot pushed a commit that referenced this pull request Jul 9, 2018
Merge pull request #65915 from nikhita/release-1.11-gc-ignored-resources
e403f7e 
Automatic merge from submit-queue.

[1.11] GC: remove CRD and APIService from ignored resources

Fixes partially #65818

This cherry-picks the GC bits for CRD and APIService from #65856. See #65856 (comment) for more details.

**Release note**:

```release-note
The garbage collector now supports CustomResourceDefinitions and APIServices.
```
k8s-github-robot pushed a commit that referenced this pull request Jul 10, 2018
Merge pull request #65916 from xmudrii/release-1.10-ignored-res
f7ef7a2 
Automatic merge from submit-queue.

[1.10] gc: remove crd and apiservice from ignored resources

Fixes #65818

This PR cherry-picks CRD and APIService removal from GC ignored resources, from #65856 and #65915.

**Release note**:
```release-note
The garbage collector now supports CustomResourceDefinitions and APIServices.
```

/cc @nikhita @liggitt 
/sig api-machinery
/kind bug
/priority important-soon
k8s-github-robot pushed a commit that referenced this pull request Jul 12, 2018
Merge pull request #65918 from nikhita/release-1.9-gc-ignored-resources
707acf5 
Automatic merge from submit-queue.

[1.9] GC: remove CRD and APIService from ignored resources

Fixes #65818

This cherry-picks the GC bits for CRD and APIService from #65856. See #65856 (comment) for more details.

**Release note**:

```release-note
The garbage collector now supports CustomResourceDefinitions and APIServices.
```
@xmudrii xmudrii mentioned this pull request Aug 29, 2018
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@xmudrii xmudrii xmudrii approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@lavalamp lavalamp Awaiting requested review from lavalamp

@roycaihw roycaihw Awaiting requested review from roycaihw

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@deads2k @k8s-ci-robot @liggitt @nikhita @k8s-github-robot @fedebongio @xmudrii