Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only need to ignore resources that match discovery conditions #65856

Merged
merged 1 commit into from Jul 6, 2018

Conversation

@deads2k
Copy link
Contributor

commented Jul 5, 2018

GC and quota controllers ignore resources that are too expensive to manage. In kube this is only events. The incompatible resources should now be excluded on the basis of discovery. We should actually reflect that in the RESTStorage (done for GC for events) and discovery too.

@liggitt
@kubernetes/sig-api-machinery-bugs

NONE
@xmudrii

xmudrii approved these changes Jul 5, 2018

Copy link
Member

left a comment

That seems to fix the issue #65818

/lgtm

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2018

@xmudrii: changing LGTM is restricted to assignees, and only kubernetes/kubernetes repo collaborators may be assigned issues.

In response to this:

That seems to fix the issue #65818

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

{Group: "", Resource: "events"}: {},
{Group: "authentication.k8s.io", Resource: "tokenreviews"}: {},

This comment has been minimized.

Copy link
@liggitt

liggitt Jul 5, 2018

Member

Does this prevent creation of these before quota objects sync?

@@ -337,17 +337,7 @@ func (gb *GraphBuilder) Run(stopCh <-chan struct{}) {
}

var ignoredResources = map[schema.GroupResource]struct{}{
{Group: "extensions", Resource: "replicationcontrollers"}: {},

This comment has been minimized.

Copy link
@liggitt

liggitt Jul 5, 2018

Member

are these not listable/watchable?

@liggitt

This comment has been minimized.

Copy link
Member

commented Jul 6, 2018

/lgtm

I think the change to CRD/APIService for GC should be picked to 1.11

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 6, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, liggitt, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nikhita

This comment has been minimized.

Copy link
Member

commented Jul 6, 2018

I think the change to CRD/APIService for GC should be picked to 1.11

I'll do it. 👍

@nikhita

This comment has been minimized.

Copy link
Member

commented Jul 6, 2018

I think the change to CRD/APIService for GC should be picked to 1.11

#65915

@k8s-github-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 6, 2018

Automatic merge from submit-queue (batch tested with PRs 65897, 65909, 65856, 65815). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit d1608c2 into kubernetes:master Jul 6, 2018

17 checks passed

Submit Queue Queued to run github e2e tests a second time.
Details
cla/linuxfoundation deads2k authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-cross Skipped
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gke Skipped
pull-kubernetes-e2e-kops-aws Job succeeded.
Details
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped
pull-kubernetes-local-e2e-containerized Skipped
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
@fedebongio

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2018

/cc @roycaihw

@k8s-ci-robot k8s-ci-robot requested a review from roycaihw Jul 9, 2018

k8s-github-robot pushed a commit that referenced this pull request Jul 9, 2018

Kubernetes Submit Queue
Merge pull request #65915 from nikhita/release-1.11-gc-ignored-resources
Automatic merge from submit-queue.

[1.11] GC: remove CRD and APIService from ignored resources

Fixes partially #65818

This cherry-picks the GC bits for CRD and APIService from #65856. See #65856 (comment) for more details.

**Release note**:

```release-note
The garbage collector now supports CustomResourceDefinitions and APIServices.
```

k8s-github-robot pushed a commit that referenced this pull request Jul 10, 2018

Kubernetes Submit Queue
Merge pull request #65916 from xmudrii/release-1.10-ignored-res
Automatic merge from submit-queue.

[1.10] gc: remove crd and apiservice from ignored resources

Fixes #65818

This PR cherry-picks CRD and APIService removal from GC ignored resources, from #65856 and #65915.

**Release note**:
```release-note
The garbage collector now supports CustomResourceDefinitions and APIServices.
```

/cc @nikhita @liggitt 
/sig api-machinery
/kind bug
/priority important-soon

k8s-github-robot pushed a commit that referenced this pull request Jul 12, 2018

Kubernetes Submit Queue
Merge pull request #65918 from nikhita/release-1.9-gc-ignored-resources
Automatic merge from submit-queue.

[1.9] GC: remove CRD and APIService from ignored resources

Fixes #65818

This cherry-picks the GC bits for CRD and APIService from #65856. See #65856 (comment) for more details.

**Release note**:

```release-note
The garbage collector now supports CustomResourceDefinitions and APIServices.
```

@xmudrii xmudrii referenced this pull request Aug 29, 2018

Closed

REQUEST: New membership for xmudrii #48

6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.