Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable dynamic azure disk volume limits #66269

Closed
andyzhangx opened this issue Jul 17, 2018 · 0 comments · Fixed by #67772
Closed

Enable dynamic azure disk volume limits #66269

andyzhangx opened this issue Jul 17, 2018 · 0 comments · Fixed by #67772
Assignees
@andyzhangx
Labels
area/cloudprovider kind/feature Categorizes issue or PR as related to a new feature.

Comments

@andyzhangx
Copy link
Member

Is this a BUG REPORT or FEATURE REQUEST?:
/kind feature

This is an azure cloud provider implementation related to feature: Dynamic Maximum volume count

Uncomment only one, leave it on its own line:

/kind bug
/kind feature

What happened:

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:

/sig azure
/area cloudprovider
/assign
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. sig/azure area/cloudprovider labels Jul 17, 2018
@andyzhangx andyzhangx mentioned this issue Aug 23, 2018
Merged
hh pushed a commit to ii/kubernetes that referenced this issue Aug 27, 2018
Merge pull request kubernetes#67772 from andyzhangx/azuredisk-volumel…
91e37ee 
…imits2

Automatic merge from submit-queue (batch tested with PRs 67766, 67642, 67772). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Enable dynamic azure disk volume limits

**What this PR does / why we need it**:
Enable dynamic azure disk volume limits,
This is an azure cloud provider implementation related to feature: [Dynamic Maximum volume count](kubernetes/enhancements#554)

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes kubernetes#66269

**Special notes for your reviewer**:
This PR use `az.VirtualMachineSizesClient.List` to list all vm sizes under region, match vm size with current node size, and then got `MaxDataDiskCount`, the `GetVolumeLimits` happens in kubelet and will return `attachable-volumes-azure-disk` in node status as following example:
```
agentpool-22082114-0
    ...
    allocatable:
      attachable-volumes-azure-disk: "8"
      cpu: "2"
      ephemeral-storage: "28043041951"
      hugepages-1Gi: "0"
      hugepages-2Mi: "0"
      memory: 7034772Ki
      pods: "30"
```

**Release note**:

```
Enable dynamic azure disk volume limits
```

/sig azure
/kind feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andyzhangx andyzhangx

Labels
area/cloudprovider kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable dynamic azure disk volume limits andyzhangx/kubernetes
2 participants
@andyzhangx @k8s-ci-robot