Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default etcd server to 3.3.10 for kubernetes 1.14 #71615

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Update default etcd server to 3.3.10 for kubernetes 1.14 #71615

merged 1 commit into from
Dec 4, 2018

Conversation

jpbetz
Copy link
Contributor

@jpbetz jpbetz commented Nov 30, 2018 •
edited

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Update default etcd server to 3.3.10 for kubernetes 1.14. etcd client was previously upgraded to 3.3.10 for kubernetes 1.14.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #61326

Special notes for your reviewer:

For reference, previous bump to 3.2.24 was performed using #68318, #68898, #68901 and #9675

Does this PR introduce a user-facing change?:

Upgrade default etcd server to 3.3.10

cc @timstclair
/sig api-machinery
/area etcd

@jpbetz jpbetz added this to the v1.13 milestone Nov 30, 2018
@jpbetz jpbetz self-assigned this Nov 30, 2018
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. area/etcd needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 30, 2018
@jpbetz jpbetz added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 30, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 30, 2018
@jpbetz
Copy link
Contributor Author

jpbetz commented Nov 30, 2018

Images have been published to gcr.io/k8s-image-staging and will shortly be promoted to http://k8s.gcr.io.

@jpbetz jpbetz mentioned this pull request Nov 30, 2018
Closed
@liggitt
Copy link
Member

liggitt commented Nov 30, 2018

is this targeting 1.13.1?

@jpbetz jpbetz changed the title Update default etcd server to 3.3.10 for kubernetes 1.13 Update default etcd server to 3.3.10 for kubernetes 1.14 Nov 30, 2018
@jpbetz
Copy link
Contributor Author

jpbetz commented Nov 30, 2018

@liggitt No, sorry, I had an off-by-one error in my k8s versions. This is targeting 1.14 with no plan to cherrypick to previous releases. I've updated the title and description to match.

@jpbetz jpbetz modified the milestones: v1.13, v1.14 Nov 30, 2018
@jpbetz
Copy link
Contributor Author

jpbetz commented Nov 30, 2018

Images published.

/retest

@k8s-ci-robot k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Nov 30, 2018
@neolit123
Copy link
Member

/cc
/assign @timothysc

timothysc
timothysc reviewed Dec 3, 2018
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Please address @luxas 's comments below.

@timothysc
Copy link
Member

/hold

@luxas please un-hold when lgtm.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2018
@timothysc timothysc added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jpbetz, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

luxas
luxas approved these changes Dec 3, 2018
View reviewed changes
Copy link
Member

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit
/hold cancel
The kubeadm and build parts looks good, not familiar with the GKE part.

Meta: we should be able to remove the v2 upgrade/rollback code

cmd/kubeadm/app/constants/constants.go
@@ -388,6 +387,7 @@ var (
11: "3.2.18",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: you may remove the 10 and 11 statements, they're not used anymore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2018
@jpbetz jpbetz force-pushed the etcd-3.3.10-0-image branch 2 times, most recently from 04cc0b6 to fb9be5e Compare December 3, 2018 18:26
@jpbetz
Copy link
Contributor Author

jpbetz commented Dec 3, 2018

@luxas Removing 1.10 and 1.11 k8s versions from kubeadm test constants broke a variety of tests in ways that were not entirely obvious to me how to fix. I've put the old versions back in the PR for now. Let's open a separate issue to remove them.

@mbohlool
Copy link
Contributor

mbohlool commented Dec 3, 2018

cc @cheftako @jingyih

@jpbetz
Copy link
Contributor Author

jpbetz commented Dec 3, 2018

/retest

2 similar comments
@jpbetz
Copy link
Contributor Author

jpbetz commented Dec 4, 2018

/retest

@jpbetz
Copy link
Contributor Author

jpbetz commented Dec 4, 2018

/retest

@luxas
Copy link
Member

luxas commented Dec 4, 2018

@luxas Removing 1.10 and 1.11 k8s versions from kubeadm test constants broke a variety of tests in ways that were not entirely obvious to me how to fix. I've put the old versions back in the PR for now. Let's open a separate issue to remove them.

Ok, np!

luxas
luxas approved these changes Dec 4, 2018
View reviewed changes
Copy link
Member

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2018
@k8s-ci-robot k8s-ci-robot merged commit a9b69dc into kubernetes:master Dec 4, 2018
dims added a commit to dims/openlab-zuul-jobs that referenced this pull request Dec 4, 2018
@dims
Update to etcd 3.3.10
ad50799 
k/k has now moved to 3.3.10 of etcd
kubernetes/kubernetes#71615

Change-Id: I450b3aff33235cc9d0d2abe5290f7c0cdf422f20
@dims dims mentioned this pull request Dec 4, 2018
Merged
@dims dims mentioned this pull request Jan 10, 2019
Merged
@wenjiaswe wenjiaswe mentioned this pull request May 13, 2019
Merged
@anton-johansson anton-johansson mentioned this pull request Feb 21, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothysc timothysc timothysc left review comments

@luxas luxas luxas approved these changes

@erictune erictune Awaiting requested review from erictune

@gmarek gmarek Awaiting requested review from gmarek

@neolit123 neolit123 Awaiting requested review from neolit123

Assignees

@timothysc timothysc

@jpbetz jpbetz

@luxas luxas

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/etcd area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.14
Development

Successfully merging this pull request may close these issues.

Bump etcd to 3.3
7 participants
@jpbetz @liggitt @luxas @neolit123 @timothysc @k8s-ci-robot @mbohlool