initOpCache is not skipping undeletable resource in namespaced_resources_deleter

[tedyu]

What happened:
In initOpCache:

                        if !verbs.Has("delete") {
                                klog.V(6).Infof("Skipping resource %v because it cannot be deleted.", gvr)
                        }

The execution doesn't continue with the next resource in the for loop which starts on line 182.

What you expected to happen:

The resource should be skipped but it seems the resource is handled as if the verb check doesn't exist.

How to reproduce it (as minimally and precisely as possible):

Found the issue during code inspection.

Anything else we need to know?:

None

Environment:

• Kubernetes version (use kubectl version):
• Cloud provider or hardware configuration:
• OS (e.g. from /etc/os-release):
• Kernel (e.g. uname -a):
• Install tools:
• Others:

@kubernetes/sig-contributor-experience-bugs

[idealhack]

Thanks for reporting this!

You can link to the code block like this:

kubernetes/pkg/controller/namespace/deletion/namespaced_resources_deleter.go

Lines 186 to 188 in bd5a4cc

	if !verbs.Has("delete") {
	klog.V(6).Infof("Skipping resource %v because it cannot be deleted.", gvr)
	}

By looking at the OWNERS file, we'd better let sig-api-machinery know about this.

/sig api-machinery
@kubernetes/sig-api-machinery-bugs

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[tedyu]

ping @derekwaynecarr @smarterclayton

[smarterclayton]

/remove-lifecycle stale

[smarterclayton]

The code is confusing since it looks like it's adding things to the list, but it's really just priming a cache. The real check is:

	deletableResources := discovery.FilteredBy(discovery.SupportsAllVerbs{Verbs: []string{"delete"}}, resources)

in deleteAllContent

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.