New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initOpCache is not skipping undeletable resource in namespaced_resources_deleter #72758

Open
tedyu opened this Issue Jan 9, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@tedyu
Copy link

tedyu commented Jan 9, 2019

What happened:
In initOpCache:

                        if !verbs.Has("delete") {
                                klog.V(6).Infof("Skipping resource %v because it cannot be deleted.", gvr)
                        }

The execution doesn't continue with the next resource in the for loop which starts on line 182.

What you expected to happen:

The resource should be skipped but it seems the resource is handled as if the verb check doesn't exist.

How to reproduce it (as minimally and precisely as possible):

Found the issue during code inspection.

Anything else we need to know?:

None

Environment:

  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:

@kubernetes/sig-contributor-experience-bugs

@tedyu tedyu added the kind/bug label Jan 9, 2019

@idealhack

This comment has been minimized.

Copy link
Member

idealhack commented Jan 16, 2019

Thanks for reporting this!

You can link to the code block like this:

if !verbs.Has("delete") {
klog.V(6).Infof("Skipping resource %v because it cannot be deleted.", gvr)
}

By looking at the OWNERS file, we'd better let sig-api-machinery know about this.

/sig api-machinery
@kubernetes/sig-api-machinery-bugs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment