Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support meta.k8s.io/v1 Table and PartialObjectMetadata requests to the API #77448

Merged
merged 2 commits into from
May 11, 2019
Merged

Support meta.k8s.io/v1 Table and PartialObjectMetadata requests to the API #77448

merged 2 commits into from
May 11, 2019

Conversation

smarterclayton
Copy link
Contributor

Clients may now request responses transformed to the v1 form of the Table and PartialObjectMetadata objects. Internally, the metav1 and metav1beta1 types are identical, except for PartialObjectMetadataList in v1beta1 which has a different, legacy protobuf ID ordering (due to a bug not caught until 1.15).

After this change clients can use the v1 version of the objects.

/kind api-change

Clients may now request that API objects are converted to the `v1.Table` and `v1.PartialObjectMetadata` forms for generic access to objects.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 4, 2019
@smarterclayton
Copy link
Contributor Author

@kubernetes/sig-api-machinery-api-reviews

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. area/apiserver area/kubectl area/test sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 4, 2019
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2019
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@smarterclayton
Make metav1beta1 be equivalent to metav1 internally
e256c15 
All except PartialObjectMetadataList are identical and should be made
that way internally. This allows the internalversion to convert between
them.
@lavalamp
Copy link
Member

lavalamp commented May 6, 2019

/assign

@smarterclayton smarterclayton force-pushed the api_serve branch 2 times, most recently from 1df1286 to 2d52bed Compare May 7, 2019 19:21
@smarterclayton
Copy link
Contributor Author

/retest

@liggitt
Copy link
Member

liggitt commented May 8, 2019

lgtm. would be good to have tests that accept v1,v1beta1 and v1beta1,v1, and ensure the preferred Content-Type is returned (since we'll switch kubectl to request both shortly, I expect)

@smarterclayton
Copy link
Contributor Author

lgtm. would be good to have tests that accept v1,v1beta1 and v1beta1,v1, and ensure the preferred Content-Type is returned (since we'll switch kubectl to request both shortly, I expect)

ack

@smarterclayton
API server should offer metav1 Table/Partial transforms
33a3e32 
Now that internal types are equivalent, allow the apiserver to serve
metav1 and metav1beta1 depending on the client. Test that in the
apiserver integration test and ensure we get the appropriate responses.

Register the metav1 type in the appropriate external locations.
@smarterclayton
Copy link
Contributor Author

Updated, folded the constant in

@liggitt
Copy link
Member

liggitt commented May 11, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 274876e into kubernetes:master May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp lavalamp left review comments

@liggitt liggitt liggitt left review comments

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@jbeda jbeda Awaiting requested review from jbeda

Assignees

@lavalamp lavalamp

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/kubectl area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@smarterclayton @fejta-bot @lavalamp @liggitt @k8s-ci-robot