-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump CoreDNS version to 1.5.0 and update manifest #78030
Conversation
/cc @chrisohaver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @rajansandeep
/approve
cc @kubernetes/sig-cluster-lifecycle-pr-reviews
/retest |
/test pull-kubernetes-e2e-kind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrHohn, neolit123, rajansandeep The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubernetes-e2e-gce-100-performance |
1 similar comment
/test pull-kubernetes-e2e-gce-100-performance |
@rajansandeep i will have a look, but we might have to revert if there is no apparent solution |
creating a cluster from the master k/k branch works fine with the new coredns version. nothing apparent in the container logs: |
@neolit123 I believe this is due to the CoreDNS ConfigMap retained during upgrade and the ‘ready’ plugin not included in the upgraded version. This causes the coredns pods to report as not-ready. This is one of the reasons why #78033 is important. |
ok, understood |
Can the failing upgrade tests be run ad-hoc in a PR? |
No. Not on a pr remotelly but locally yes using the tool kinder. However i think the failure is reproducible with a regular 1.14 - master upgrade |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Updates the version of CoreDNS to 1.5.0 and also updates the manifests.
Which issue(s) this PR fixes:
Fixes #78003
Special notes for your reviewer:
Does this PR introduce a user-facing change?: