Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CoreDNS version to 1.5.0 and update manifest #78030

Merged
merged 1 commit into from
May 18, 2019
Merged

Bump CoreDNS version to 1.5.0 and update manifest #78030

merged 1 commit into from
May 18, 2019

Conversation

rajansandeep
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:
Updates the version of CoreDNS to 1.5.0 and also updates the manifests.

Which issue(s) this PR fixes:

Fixes #78003

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

CoreDNS is now version 1.5.0
    - A `ready` plugin has been included to report pod readiness
    - The `proxy` plugin has been deprecated. The `forward` plugin is to be used instead.
    - CoreDNS fixes the logging now that kubernetes’ client lib switched to klog from glog.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 17, 2019
@rajansandeep
Copy link
Contributor Author

/cc @chrisohaver

Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @rajansandeep
/approve
cc @kubernetes/sig-cluster-lifecycle-pr-reviews

@neolit123
Copy link
Member

/retest

@neolit123
Copy link
Member

/test pull-kubernetes-e2e-kind

Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, neolit123, rajansandeep

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2019
@rajansandeep
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-100-performance

1 similar comment
@rosti
Copy link
Contributor

rosti commented May 17, 2019

/test pull-kubernetes-e2e-gce-100-performance

@k8s-ci-robot k8s-ci-robot merged commit 648cb98 into kubernetes:master May 18, 2019
@neolit123
Copy link
Member

@rajansandeep
looks like the bump broke kubeadm upgrade e2e:
https://k8s-testgrid.appspot.com/sig-cluster-lifecycle-kubeadm#kubeadm-kinder-upgrade-stable-master
72f6954...a67f128

i will have a look, but we might have to revert if there is no apparent solution
cc @fabriziopandini

@rajansandeep
Copy link
Contributor Author

@neolit123 I believe this is due to the CoreDNS ConfigMap retained during upgrade and the ‘ready’ plugin not included in the upgraded version. This causes the coredns pods to report as not-ready.

This is one of the reasons why #78033 is important.

@neolit123
Copy link
Member

ok, understood
it would have been better to get #78033 in first to have the migrate logic in place before the version bump.

@chrisohaver
Copy link
Contributor

Can the failing upgrade tests be run ad-hoc in a PR?

@neolit123
Copy link
Member

No. Not on a pr remotelly but locally yes using the tool kinder. However i think the failure is reproducible with a regular 1.14 - master upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade coredns to v1.4.0 or v1.5.0
6 participants