Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to go 1.12.8 #81390

Merged
merged 3 commits into from Aug 14, 2019
Merged

Update to go 1.12.8 #81390

merged 3 commits into from Aug 14, 2019

Conversation

cblecker
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:
Update to go 1.12.8

Which issue(s) this PR fixes:
ref #79912

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update to use go 1.12.8

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 13, 2019
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 13, 2019
@cblecker
Copy link
Member Author

/priority critical-urgent
/sig release

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/release Categorizes an issue or PR as relevant to SIG Release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 13, 2019
@cblecker
Copy link
Member Author

Still to be done:

@cblecker cblecker mentioned this pull request Aug 13, 2019
Closed
@BenTheElder
Copy link
Member

/assign

@cblecker
Copy link
Member Author

/assign @javier-b-perez
Would you mind building and pushing the image, Javier?

BenTheElder
BenTheElder approved these changes Aug 13, 2019
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2019
@BenTheElder
Copy link
Member

I built / pushed an image, the CL is pending

@javier-b-perez
Copy link
Contributor

/lgtm

@cblecker
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2019
@BenTheElder
Copy link
Member

/test pull-kubernetes-verify

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 14, 2019
@tao12345666333 tao12345666333 mentioned this pull request Aug 14, 2019
Closed
@cblecker
Copy link
Member Author

/test pull-kubernetes-bazel-test

@cblecker
Fix malformed port in vsphere cloud provider test
f713ec8 
The port name previously didn't matter on these tests, but is now
actively being checked in go1.12.8 and higher.

golang/go@3226f2d
@k8s-ci-robot k8s-ci-robot added area/cloudprovider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 14, 2019
@cblecker
Copy link
Member Author

Pushed up a new commit to fix a test failure:

Tests under go1.12.7:

$ docker run --rm -v ${PWD}:/go/src/k8s.io/kubernetes -w /go/src/k8s.io/kubernetes golang:1.12.7 go test -v ./vendor/k8s.io/legacy-cloud-providers/vsphere/vclib/... -run '(TestWithInvalidCaCertPath|TestInvalidCaCert)'
=== RUN   TestWithInvalidCaCertPath
--- PASS: TestWithInvalidCaCertPath (0.00s)
=== RUN   TestInvalidCaCert
--- PASS: TestInvalidCaCert (0.00s)
PASS
ok      k8s.io/kubernetes/vendor/k8s.io/legacy-cloud-providers/vsphere/vclib    0.027s
?       k8s.io/kubernetes/vendor/k8s.io/legacy-cloud-providers/vsphere/vclib/diskmanagers       [no test files]
?       k8s.io/kubernetes/vendor/k8s.io/legacy-cloud-providers/vsphere/vclib/fixtures   [no test files]

Tests under go1.12.8:

docker run --rm -v ${PWD}:/go/src/k8s.io/kubernetes -w /go/src/k8s.io/kubernetes golang:1.12.8 go test -v ./vendor/k8s.io/legacy-cloud-providers/vsphere/vclib/... -run '(TestWithInvalidCaCertPath|TestInvalidCaCert)'
=== RUN   TestWithInvalidCaCertPath
E0814 04:43:25.865720    1179 connection.go:179] Failed to parse URL: <nil>. err: parse https://should-not-matter:should-not-matter: invalid port ":should-not-matter" after host
--- FAIL: TestWithInvalidCaCertPath (0.00s)
    connection_test.go:168: Expected an os.PathError, got: 'parse https://should-not-matter:should-not-matter: invalid port ":should-not-matter" after host' (&url.Error{Op:"parse", URL:"https://should-not-matter:should-not-matter", Err:(*errors.errorString)(0xc00003f8d0)})
=== RUN   TestInvalidCaCert
E0814 04:43:25.866151    1179 connection.go:179] Failed to parse URL: <nil>. err: parse https://should-not-matter:should-not-matter: invalid port ":should-not-matter" after host
--- FAIL: TestInvalidCaCert (0.00s)
    connection_test.go:182: Expected invalid certificate error, got 'parse https://should-not-matter:should-not-matter: invalid port ":should-not-matter" after host'
FAIL
FAIL    k8s.io/kubernetes/vendor/k8s.io/legacy-cloud-providers/vsphere/vclib    0.024s
?       k8s.io/kubernetes/vendor/k8s.io/legacy-cloud-providers/vsphere/vclib/diskmanagers       [no test files]
?       k8s.io/kubernetes/vendor/k8s.io/legacy-cloud-providers/vsphere/vclib/fixtures   [no test files]

Tests under go1.12.8 after fix:

$ docker run --rm -v ${PWD}:/go/src/k8s.io/kubernetes -w /go/src/k8s.io/kubernetes golang:1.12.8 go test -v ./vendor/k8s.io/legacy-cloud-providers/vsphere/vclib/... -run '(TestWithInvalidCaCertPath|TestInvalidCaCert)'
=== RUN   TestWithInvalidCaCertPath
--- PASS: TestWithInvalidCaCertPath (0.00s)
=== RUN   TestInvalidCaCert
--- PASS: TestInvalidCaCert (0.00s)
PASS
ok      k8s.io/kubernetes/vendor/k8s.io/legacy-cloud-providers/vsphere/vclib    0.026s
?       k8s.io/kubernetes/vendor/k8s.io/legacy-cloud-providers/vsphere/vclib/diskmanagers       [no test files]
?       k8s.io/kubernetes/vendor/k8s.io/legacy-cloud-providers/vsphere/vclib/fixtures   [no test files]

@cblecker
Copy link
Member Author

/test pull-kubernetes-integration

@cblecker
Copy link
Member Author

/retest

imkin
imkin reviewed Aug 14, 2019
View reviewed changes
staging/src/k8s.io/legacy-cloud-providers/vsphere/vclib/connection_test.go
@@ -159,7 +159,7 @@ func TestWithValidThumbprint(t *testing.T) {
func TestWithInvalidCaCertPath(t *testing.T) {
connection := &vclib.VSphereConnection{
Hostname: "should-not-matter",
Port: "should-not-matter",
Copy link

@imkin imkin Aug 14, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could have been a fixture too may be. But its "doesn't matter" so may be we can live with this.

@imkin
Copy link

imkin commented Aug 14, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2019
@imkin
Copy link

imkin commented Aug 14, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker, imkin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2019
BenTheElder
BenTheElder reviewed Aug 14, 2019
View reviewed changes
hack/boilerplate/boilerplate_test.py
@@ -16,7 +16,7 @@

import boilerplate
import unittest
import StringIO
from io import StringIO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems unrelated? how did the go bump switch this to python3?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bazel was failing this test locally on my side when I bumped things. May be my setup?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah. I thought we had it configured to force python2 /shrug
as long as it passes in CI, seems good to me

@k8s-ci-robot k8s-ci-robot merged commit 3526a61 into kubernetes:master Aug 14, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 14, 2019
@warmchang warmchang mentioned this pull request Aug 15, 2019
Merged
@cblecker cblecker deleted the go-1.12.8 branch August 15, 2019 03:40
@buribae buribae mentioned this pull request Aug 15, 2019
Closed
imkin pushed a commit to imkin/kubernetes that referenced this pull request Aug 15, 2019
@k8s-ci-robot
Merge pull request kubernetes#81390 from cblecker/go-1.12.8
1632750 
Update to go 1.12.8
This was referenced Aug 16, 2019
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Aug 16, 2019
@k8s-ci-robot
Merge pull request #81521 from cblecker/automated-cherry-pick-of-#78958-
96fac5c 
#79966-#81390-#81489-upstream-release-1.14

Update release-1.14 to go 1.12.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@imkin imkin imkin left review comments

@mkumatag mkumatag Awaiting requested review from mkumatag

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@BenTheElder BenTheElder

@imkin imkin

@javier-b-perez javier-b-perez

@warmchang warmchang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cblecker @BenTheElder @javier-b-perez @warmchang @imkin @k8s-ci-robot