Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update go to 1.12.9 #81489

Merged
merged 1 commit into from Aug 16, 2019
Merged

update go to 1.12.9 #81489

merged 1 commit into from Aug 16, 2019

Conversation

BenTheElder
Copy link
Member

@BenTheElder BenTheElder commented Aug 16, 2019 •
edited by cblecker

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it: updates go to 1.12.9 which includes bug fixes

Which issue(s) this PR fixes:

ref #79912

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update to use go 1.12.9

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 16, 2019
@BenTheElder
Copy link
Member Author

/cc @cblecker

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 16, 2019
@cblecker
Copy link
Member

/priority critical-urgent
/lgtm
/approve
/woof

@k8s-ci-robot
Copy link
Contributor

@cblecker: dog image

In response to this:

/priority critical-urgent
/lgtm
/approve
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2019
@BenTheElder
Copy link
Member Author

corrected the rules_go URL, cross checked with the workspace spec in their release notes. 🙃

@BenTheElder
Copy link
Member Author

/sig release

@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Aug 16, 2019
@cblecker
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2019
@BenTheElder
Copy link
Member Author

/retest
k8s.gcr.io/kube-cross:v1.12.9-1 is now live.

@warmchang
Copy link
Contributor

/test pull-kubernetes-verify

@tao12345666333 tao12345666333 mentioned this pull request Aug 16, 2019
Merged
@BenTheElder
Copy link
Member Author

/retest

@warmchang
Copy link
Contributor

/test pull-kubernetes-kubemark-e2e-gce-big

@k8s-ci-robot k8s-ci-robot merged commit e283836 into kubernetes:master Aug 16, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 16, 2019
@BenTheElder BenTheElder deleted the go-1.12.9 branch August 16, 2019 14:53
This was referenced Aug 16, 2019
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Aug 16, 2019
@k8s-ci-robot
Merge pull request #81520 from cblecker/automated-cherry-pick-of-#81390-
7812423 
#81489-upstream-release-1.15

Update release-1.15 to go 1.12.9
k8s-ci-robot added a commit that referenced this pull request Aug 16, 2019
@k8s-ci-robot
Merge pull request #81521 from cblecker/automated-cherry-pick-of-#78958-
96fac5c 
#79966-#81390-#81489-upstream-release-1.14

Update release-1.14 to go 1.12.9
@BenTheElder BenTheElder mentioned this pull request Aug 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@listx listx Awaiting requested review from listx

@spiffxp spiffxp Awaiting requested review from spiffxp

@cblecker cblecker Awaiting requested review from cblecker

Assignees

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BenTheElder @cblecker @k8s-ci-robot @warmchang