Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hyperkube from release artifacts #83454

Merged
merged 1 commit into from
Oct 5, 2019
Merged

Remove hyperkube from release artifacts #83454

merged 1 commit into from
Oct 5, 2019

Conversation

dims
Copy link
Member

@dims dims commented Oct 3, 2019 •
edited

Related to #81760

Just like what we did with cloud-controller-manager, this serves as a signal for folks that hyperkube will go to a new repository and will no longer be available from k/k.

Change-Id: Ie09248d6fc688ffffbeb0271824817a5129346a0

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

hyperkube will now be available in a new github repository and will not be included in the kubernetes release from 1.17 onwards

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 3, 2019
@dims
Remove hyperkube from release artifacts
138571b 
Change-Id: Ie09248d6fc688ffffbeb0271824817a5129346a0
@dims dims force-pushed the cleanup-hyperkube-from-release-artifacts branch from 49eb7ed to 138571b Compare October 3, 2019 17:33
@dims
Copy link
Member Author

dims commented Oct 4, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 4, 2019
@dims dims changed the title [WIP] Remove hyperkube from release artifacts Remove hyperkube from release artifacts Oct 4, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 4, 2019
@dims
Copy link
Member Author

dims commented Oct 4, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 4, 2019
@dims
Copy link
Member Author

dims commented Oct 4, 2019

/assign @mikedanese @cblecker

@dims
Copy link
Member Author

dims commented Oct 4, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

1 similar comment
@dims
Copy link
Member Author

dims commented Oct 4, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@dims
Copy link
Member Author

dims commented Oct 4, 2019

/milestone v1.17
/sig release
/assign @justaugustus

@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Oct 4, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 4, 2019
fejta
fejta reviewed Oct 4, 2019
View reviewed changes
Copy link
Contributor

@fejta fejta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@dims dims mentioned this pull request Oct 4, 2019
Merged
@jbeda
Copy link
Contributor

jbeda commented Oct 4, 2019

/approve

sigh I had dreams for hyperkube but never made it happen.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2019
cblecker
cblecker approved these changes Oct 4, 2019
View reviewed changes
Copy link
Member

@cblecker cblecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold

@kubernetes/release-engineering: FYI -- this will change the release artifacts.

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 4, 2019
@dims
Copy link
Member Author

dims commented Oct 5, 2019

@justaugustus @tpepper PTAL and remove /hold if appropriate.

@justaugustus
Copy link
Member

Thanks for pouncing on this, @dims!
/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, dims, fejta, jbeda, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7c540ec into kubernetes:master Oct 5, 2019
@dims dims mentioned this pull request Oct 9, 2019
Closed
rfranzke added a commit to gardener/gardener that referenced this pull request Dec 22, 2019
@rfranzke
Don't use deprecated hyperkube image anymore for 1.17+ clusters
f3604c9 
See kubernetes/kubernetes#81760 and kubernetes/kubernetes#83454
rfranzke added a commit to gardener/gardener that referenced this pull request Dec 22, 2019
@rfranzke
Don't use deprecated hyperkube image anymore for 1.17+ clusters
c96d8af 
See kubernetes/kubernetes#81760 and kubernetes/kubernetes#83454
rfranzke added a commit to gardener/gardener that referenced this pull request Dec 27, 2019
@rfranzke
Don't use deprecated hyperkube image anymore for 1.17+ clusters
2283808 
See kubernetes/kubernetes#81760 and kubernetes/kubernetes#83454
@superseb superseb mentioned this pull request Feb 7, 2020
Closed
@tallclair
Copy link
Member

This PR left some hyperkube files behind, notably:

Is it safe to remove those directories now? If not, what is the roadmap for migrating them out?

My interest in the matter is that debian-hyperkube-base is super stale and full of CVEs.

@justaugustus
Copy link
Member

@tallclair -- Allow me to look into this.

@justaugustus justaugustus mentioned this pull request Mar 1, 2020
Merged
@justaugustus
Copy link
Member

Is it safe to remove those directories now? If not, what is the roadmap for migrating them out?

@tallclair -- Dims is working on this in #88676

@xmudrii xmudrii mentioned this pull request May 22, 2020
Closed
@JohnJAS JohnJAS mentioned this pull request Jun 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fejta fejta fejta left review comments

@cblecker cblecker cblecker approved these changes

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@justaugustus justaugustus

@cblecker cblecker

@mikedanese mikedanese

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@dims @jbeda @justaugustus @k8s-ci-robot @tallclair @fejta @cblecker @mikedanese