Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default etcd server to 3.4.3 #84329

Merged
merged 2 commits into from Oct 30, 2019
Merged

Update default etcd server to 3.4.3 #84329

merged 2 commits into from Oct 30, 2019

Conversation

jingyih
Copy link
Contributor

@jingyih jingyih commented Oct 25, 2019 •
edited

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
We are updating etcd client version to 3.4.3 in #83987. This PR updates the default etcd server version to 3.4.3.

Does this PR introduce a user-facing change?:

Update default etcd server version to 3.4.3

/sig api-machinery
/area etcd
/priority important-soon

Fixes: #82641

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/etcd needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 25, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @jingyih. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 25, 2019
@k8s-ci-robot k8s-ci-robot added area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/kubeadm area/test sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 25, 2019
@jingyih
Copy link
Contributor Author

jingyih commented Oct 25, 2019

/hold
Until 3.4.3 image is pushed.
Until #83987 is merged.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Oct 25, 2019
wenjiaswe
wenjiaswe reviewed Oct 25, 2019
View reviewed changes
cmd/kubeadm/app/constants/constants.go
@@ -425,8 +425,8 @@ var (
14: "3.3.10",
15: "3.3.10",
16: "3.3.15-0",
17: "3.3.17-0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to change default of 16 to 3.3.17-0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. ref: #83968

Copy link
Contributor

@jpbetz jpbetz Oct 25, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'm in favor of updating to same patch version for all k8s versions using 3.3 in kubeadm.

@jingyih jingyih force-pushed the update_etcd_server_to_3.4 branch 2 times, most recently from bfff515 to bbddd75 Compare October 26, 2019 00:46
@BenTheElder
Copy link
Member

what's the process to get the images pushed?

@jingyih
Copy link
Contributor Author

jingyih commented Oct 28, 2019

what's the process to get the images pushed?

My current understanding of the process:

  1. build and push etcd-related images to gcr.io/k8s-image-staging

  2. test the new images in K8s cluster

  3. promote images from staging repo to gcr.io/google-containers via registry promoter.

@jpbetz
Copy link
Contributor

jpbetz commented Oct 28, 2019

cc @listx for ongoing gcr.io/google-containers promotion improvement efforts

@neolit123
Copy link
Member

/approve
for kubeadm. thanks!

@jingyih
Copy link
Contributor Author

jingyih commented Oct 29, 2019

The 3.4.3 version of etcd and etcd-empty-dir-cleanup images are available in gcr.io/google-containers.
Can we get an "ok-to-test"?

@wenjiaswe
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 29, 2019
@jingyih
Copy link
Contributor Author

jingyih commented Oct 29, 2019

/retest

@jingyih
Copy link
Contributor Author

jingyih commented Oct 29, 2019

/test pull-kubernetes-e2e-gce

@jingyih jingyih changed the title [WIP] Update default etcd server to 3.4.3 Update default etcd server to 3.4.3 Oct 29, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 29, 2019
@jingyih
Copy link
Contributor Author

jingyih commented Oct 29, 2019

All tests passed. PTAL.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2019
@jingyih
Copy link
Contributor Author

jingyih commented Oct 29, 2019

/cc @liggitt @dims @wojtek-t

@neolit123
Copy link
Member

neolit123 commented Oct 29, 2019 •
edited

/test pull-kubernetes-e2e-kind
should end in about 20 minutes (creates a kubeadm / kind cluster using the new etcd).

@wojtek-t
Copy link
Member

/lgtm
/approve

Let's merge this asap to have as much soaking time as possible before the release.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingyih, neolit123, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit e1d3cc7 into kubernetes:master Oct 30, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 30, 2019
@chewong chewong mentioned this pull request Oct 31, 2019
Closed
This was referenced Jan 10, 2020
Closed
Closed
@jingyih jingyih mentioned this pull request Mar 16, 2020
Closed
@anton-johansson anton-johansson mentioned this pull request Aug 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbetz jpbetz jpbetz left review comments

@wenjiaswe wenjiaswe wenjiaswe left review comments

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@cheftako cheftako Awaiting requested review from cheftako

@dims dims Awaiting requested review from dims

@liggitt liggitt Awaiting requested review from liggitt

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/etcd area/kubeadm area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

Update to etcd 3.4 in Kubernetes 1.17 release
7 participants
@jingyih @k8s-ci-robot @BenTheElder @jpbetz @neolit123 @wenjiaswe @wojtek-t