Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vendored MountSensitive code for Windows #89319

Merged
merged 2 commits into from Mar 21, 2020
Merged

Update vendored MountSensitive code for Windows #89319

merged 2 commits into from Mar 21, 2020

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented Mar 20, 2020 •
edited by liggitt

What type of PR is this?

/kind bug

What this PR does / why we need it:
Fixes volume mounts on Windows in the 1.18.0-rc.1 release via the changes in kubernetes/utils#148.

Which issue(s) this PR fixes:
Fixes #89276

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Resolved a regression in v1.18.0-rc.1 mounting windows volumes

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 20, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @mboersma. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mboersma mboersma mentioned this pull request Mar 20, 2020
Closed
@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Mar 20, 2020
@k8s-ci-robot k8s-ci-robot requested review from smarterclayton, thockin and a team March 20, 2020 20:44
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 20, 2020
@chewong
Copy link
Member

chewong commented Mar 20, 2020 •
edited

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. area/apiserver area/cloudprovider area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 20, 2020
@marosset marosset force-pushed the fix-mount-sensitive-windows-master branch from 046d394 to e727149 Compare March 20, 2020 21:18
@liggitt
Copy link
Member

liggitt commented Mar 20, 2020

mechanics of the bump look good. cc @kubernetes/sig-storage-pr-reviews on other mount changes that came in along with the change we care about

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Mar 20, 2020
@chewong
Copy link
Member

chewong commented Mar 20, 2020

/test pull-kubernetes-e2e-azure-disk-vmss
/test pull-kubernetes-e2e-azure-file

@marosset
Copy link
Contributor

/test pull-kubernetes-e2e-azure-disk-vmss

andyzhangx
andyzhangx approved these changes Mar 21, 2020
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2020
@andyzhangx
Copy link
Member

/assign @saad-ali
could you approve? thanks.

@andyzhangx andyzhangx mentioned this pull request Mar 21, 2020
Closed
@liggitt liggitt mentioned this pull request Mar 21, 2020
Closed
@liggitt
Copy link
Member

liggitt commented Mar 21, 2020

Reviewed/approved in #89189

/approve

@liggitt
Copy link
Member

liggitt commented Mar 21, 2020

This is all set. Can you go ahead and open the release-1.18 cherry-pick of this

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2020
@andyzhangx andyzhangx mentioned this pull request Mar 21, 2020
Merged
@k8s-ci-robot k8s-ci-robot merged commit ca82b32 into kubernetes:master Mar 21, 2020
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.18, v1.19 Mar 21, 2020
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 21, 2020
k8s-ci-robot added a commit that referenced this pull request Mar 21, 2020
@k8s-ci-robot
Merge pull request #89331 from andyzhangx/automated-cherry-pick-of-#8…
35d71ed 
…9319-upstream-release-1.18

Automated cherry pick of #89319: Update vendored MountSensitive code for Windows
@mboersma mboersma deleted the fix-mount-sensitive-windows-master branch March 23, 2020 16:23
This was referenced Mar 23, 2020
Closed
Closed
@fedebongio
Copy link
Contributor

/cc @yliaog

@saad-ali saad-ali mentioned this pull request Mar 25, 2020
Closed
wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020
@k8s-publishing-bot
Merge pull request kubernetes#89331 from andyzhangx/automated-cherry-…
758a68b 
…pick-of-#89319-upstream-release-1.18

Automated cherry pick of kubernetes#89319: Update vendored MountSensitive code for Windows

Kubernetes-commit: 35d71ed
@mboersma mboersma mentioned this pull request Aug 4, 2020
Closed
6 tasks
@mboersma mboersma mentioned this pull request Aug 18, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@kvaps kvaps kvaps left review comments

@andyzhangx andyzhangx andyzhangx approved these changes

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@thockin thockin Awaiting requested review from thockin

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

Windows volume mounts failing in 1.18.0-rc.1
8 participants
@mboersma @k8s-ci-robot @chewong @marosset @liggitt @andyzhangx @fedebongio @kvaps