Missing defaults and clarifying info for kube-controller-manager

[jayunit100]

What happened:

In the KCM we're missing output about a few defaults, and probably a few of the options could use some clarity around --allocate-node-cidrs , --cloud-controller-manager, and i believe several other options have no Default: note, See
https://kubernetes.io/docs/reference/command-line-tools-reference/kube-controller-manager/ for details.

What you expected to happen:

All Options for the controller-manager have similar detail level with all Default values being listed.

How to reproduce it (as minimally and precisely as possible):

Browse https://kubernetes.io/docs/reference/command-line-tools-reference/kube-controller-manager/ or run kube-controller-manager --help

Anything else we need to know?:

See https://github.com/kubernetes/kubernetes/blob/master/cmd/controller-manager/app/options/kubecloudshared.go

Environment:

• Kubernetes version (use kubectl version): master

[jayunit100]

Controller manager issue, so i guess its api-machinery ? But also its a

/good-first-issue
/sig api-machinery

[k8s-ci-robot]

@jayunit100:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Controller manager issue, so i guess its api-machinery ? But also its a

/good-first-issue
/sig api-machinery

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

@jayunit100: The label(s) sig/ cannot be applied, because the repository doesn't have them

In response to this:

Controller manager issue, so i guess its api-machinery ? But also its a

/good-first-issue
/sig api-machinery

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ykakarap]

@jayunit100 is the expectation to just update the reference docs with the Default: note for all the options applicable?

[fedebongio]

/assign @cheftako @cici37 @jiahuif

[gfelixc]

Could I pick this up as my first issue?

[cheftako]

Hi @gfelixc, if you still interested, please feel free to pick up this issue. If you have any questions, feel free to reach out on Slack. (I'm cheftako there as well)

[gfelixc]

Hi @cheftako. Yes, I'm still interested. Thanks

[cheftako]

/assign @gfelixc

[cheftako]

Happy to help, feel free to reach out on this issue or on slack (I'm cheftako there as well).

[mayankshah1607]

Hi @gfelixc . Are you still working on this one?

[gfelixc]

Hi @mayankshah1607, Yes, I'm still working on it

[xiaopeng-han]

/assign

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[cheftako]

/remove-lifecycle stale

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[xiaopeng-han]

/assign

[almas33]

Hi @xiaopeng-han i looked at code base and this is what i think is supposed to be done
please point me in the right direction if i am wrong

for eg-
this is structure -
`// AttachDetachControllerConfiguration contains elements describing AttachDetachController.
type AttachDetachControllerConfiguration struct {
// Reconciler runs a periodic loop to reconcile the desired state of the with
// the actual state of the world by triggering attach detach operations.
// This flag enables or disables reconcile. Is false by default, and thus enabled.

DisableAttachDetachReconcilerSync bool

// ReconcilerSyncLoopPeriod is the amount of time the reconciler sync states loop
// wait between successive executions. Is set to 5 sec by default.

ReconcilerSyncLoopPeriod metav1.Duration

}`

and we are setting a default and its value displays it-

func RecommendedDefaultAttachDetachControllerConfiguration(obj *kubectrlmgrconfigv1alpha1.AttachDetachControllerConfiguration) { zero := metav1.Duration{} if obj.ReconcilerSyncLoopPeriod == zero { obj.ReconcilerSyncLoopPeriod = metav1.Duration{Duration: 60 * time.Second} } }

https://kubernetes.io/docs/reference/command-line-tools-reference/kube-controller-manager/
in this link
--attach-detach-reconcile-sync-period duration Default: 1m0s its default value displays
--disable-attach-detach-reconcile-sync but its doesn't
so we have have to add a function which sets default value to false(although its already false) so that it displays

[almas33]

Hi @cheftako i am new here and needs some help while trying to resolve this bug please see if my above observations are correct

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

[cheftako]

/remove-lifecycle rotten

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[cheftako]

/remove-lifecycle stale

[krmayankk]

/assign @stevemcquaid

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[stevemcquaid]

/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[kuntal1996]

Is this issue still open.?

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.