Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sig-network] EndpointSlice should create and delete Endpoints and EndpointSlices for a Service with a selector specified #92776

Closed
RobertKielty opened this issue Jul 3, 2020 · 17 comments
Assignees
Labels
area/deflake Issues or PRs related to deflaking kubernetes tests area/test kind/flake Categorizes issue or PR as related to a flaky test. sig/network Categorizes an issue or PR as relevant to SIG Network. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@RobertKielty
Copy link
Member

Which jobs are flaking:
gce-ubuntu-master-default

Which test(s) are flaking:
[sig-network] EndpointSlice should create and delete Endpoints and EndpointSlices for a Service with a selector specified

Testgrid link:
https://testgrid.k8s.io/sig-release-master-informing#gce-ubuntu-master-default&sort-by-flakiness=&embed=

Reason for failure:
from Spyglass for job 1278952987569426433

we have

I0703 07:42:24.519 Jul 3 07:42:20.620: FAIL: EndpointSlice resource not deleted after Service endpointslice-3248/example-empty-selector was deleted: timed out waiting for the condition

following thru to the corresponding gubernator logs/ci-kubernetes-e2e-ubuntu-gce/1278952987569426433/

we see lot of occurrences of

W0703 07:45:10.958376 8 request.go:161] Auditing failed of request: encoding failed: /v1, Kind=DeleteOptions is unstructured and is not suitable for converting to "cloud.google.com/v1beta1"

Anything else we need to know:

  • links to go.k8s.io/triage appreciated
@RobertKielty RobertKielty added the kind/flake Categorizes issue or PR as related to a flaky test. label Jul 3, 2020
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jul 3, 2020
@RobertKielty
Copy link
Member Author

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 3, 2020
@athenabot
Copy link

/triage unresolved

Comment /remove-triage unresolved when the issue is assessed and confirmed.

🤖 I am a bot run by vllry. 👩‍🔬

@k8s-ci-robot k8s-ci-robot added the triage/unresolved Indicates an issue that can not or will not be resolved. label Jul 3, 2020
@gaurimadhok
Copy link

/assign @robscott

@robscott
Copy link
Member

robscott commented Jul 9, 2020

Thanks for filing this bug @RobertKielty! The encoding failed: /v1, Kind=DeleteOptions is a very strange error message, not sure what's happening there. Am I correct that this test has only failed once? Are there other test failures elsewhere?

@athenabot
Copy link

@robscott
If this issue has been triaged, please comment /remove-triage unresolved.

If you aren't able to handle this issue, consider unassigning yourself and/or adding the help-wanted label.

🤖 I am a bot run by vllry. 👩‍🔬

@robscott
Copy link
Member

@RobertKielty do you think we can close this bug now? I haven't seen this fail recently.

@RobertKielty
Copy link
Member Author

RobertKielty commented Jul 23, 2020

Hi @robscott thanks for pinging me on this issue.

I'm still seeing EndpointSlice resource not deleted errors (admittedly on other jobs)

https://storage.googleapis.com/k8s-gubernator/triage/index.html?pr=1&text=EndpointSlice%20resource%20not%20deleted%20after%20Service

EndpointSlice resource not deleted after Service endpointslice-3248/example-empty-selector was deleted: timed out waiting for the condition

cc @hasheddan What do you think we should do here?

@robscott
Copy link
Member

Hey @RobertKielty, thanks for letting me know about the other failures! This is a tricky one since it's a timeout on garbage collection which could take a variable amount of time. I've opened a new PR that increases the timeout by 50%, hopefully that will be sufficient: #93402

@RobertKielty
Copy link
Member Author

Thanks Rob !

@liggitt
Copy link
Member

liggitt commented Jul 26, 2020

still showing up - see https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/93264/pull-kubernetes-e2e-gce/1287128021647495169

garbage collection is susceptible to interruption if API groups are being added/removed frequently (which happens all the time in e2e test runs, see investigation of a prior GC timeout issue in #87668 (comment))

@bridgetkromhout
Copy link
Member

@robscott to follow up - this is failing because garbage collection is taking too long

@athenabot
Copy link

@robscott
If this issue has been triaged, please comment /remove-triage unresolved.

If you aren't able to handle this issue, consider unassigning yourself and/or adding the help-wanted label.

🤖 I am a bot run by vllry. 👩‍🔬

1 similar comment
@athenabot
Copy link

@robscott
If this issue has been triaged, please comment /remove-triage unresolved.

If you aren't able to handle this issue, consider unassigning yourself and/or adding the help-wanted label.

🤖 I am a bot run by vllry. 👩‍🔬

@thockin thockin added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/unresolved Indicates an issue that can not or will not be resolved. labels Oct 15, 2020
@thockin thockin added triage/accepted Indicates an issue or PR is ready to be actively worked on. area/deflake Issues or PRs related to deflaking kubernetes tests area/test and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 16, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 14, 2021
@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 14, 2021
@k8s-ci-robot
Copy link
Contributor

@liggitt: Closing this issue.

In response to this:

no flakes in last two weeks
https://testgrid.k8s.io/sig-release-master-informing#gce-ubuntu-master-default&sort-by-flakiness=&embed=&width=5&show-stale-tests=&include-filter-by-regex=EndpointSlice

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/deflake Issues or PRs related to deflaking kubernetes tests area/test kind/flake Categorizes issue or PR as related to a flaky test. sig/network Categorizes an issue or PR as relevant to SIG Network. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

9 participants